Add license to checklicenses.py for protobuf

Add license to checklicenses.py for protobuf

'third_party/protobuf/conformance/third_party/jsoncpp/jsoncpp.cpp' has
non-whitelisted license 'MIT/X11 (BSD like) Public domain MIT/X11 (BSD like)'

The file is released public domain, or MIT/X11 wherever this is not legally
possible.

BUG=597321
Committed: https://crrev.com/2a79b8edf66ed993190047d4867a3c8fb221ceaa
Cr-Commit-Position: refs/heads/master@{#388276}

[xyzzyz, 2016-04-18 20:15:42]

xyzzyz@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, thestig@chromium.org

[xyzzyz, 2016-04-18 20:15:43]

phajdan.jr@chromium.org: Please review changes in 

thestig@chromium.org: Please review changes in 

https://codereview.chromium.org/1893333005

[Lei Zhang, 2016-04-18 20:27:38]

Shouldn't this be part of a larger CL?

[xyzzyz, 2016-04-18 20:37:33]

On 2016/04/18 20:27:38, Lei Zhang wrote:
> Shouldn't this be part of a larger CL?

I don't know -- do the trybots use the script from the CL itself, or do they
keep their own copy they sync periodically?

I wanted to do it separately to avoid pulling even more people to work on the CL
that's already pretty large and difficult to work with. If you think I should do
it in a single CL, let me know.

[xyzzyz, 2016-04-18 20:37:33]

On 2016/04/18 20:27:38, Lei Zhang wrote:
> Shouldn't this be part of a larger CL?

I don't know -- do the trybots use the script from the CL itself, or do they
keep their own copy they sync periodically?

I wanted to do it separately to avoid pulling even more people to work on the CL
that's already pretty large and difficult to work with. If you think I should do
it in a single CL, let me know.

[Lei Zhang, 2016-04-18 20:51:55]

On 2016/04/18 20:37:33, xyzzyz wrote:
> On 2016/04/18 20:27:38, Lei Zhang wrote:
> > Shouldn't this be part of a larger CL?
> 
> I don't know -- do the trybots use the script from the CL itself, or do they
> keep their own copy they sync periodically?

From the CL itself. Otherwise you get all kinds of chicken and egg problems.

> I wanted to do it separately to avoid pulling even more people to work on the
CL
> that's already pretty large and difficult to work with. If you think I should
do
> it in a single CL, let me know.

It's one more file and 1 more reviewer. If that's too much, at least reference
the CL that depends on this CL for context.

[xyzzyz, 2016-04-18 21:03:26]

On 2016/04/18 20:51:55, Lei Zhang wrote:
> On 2016/04/18 20:37:33, xyzzyz wrote:
> > On 2016/04/18 20:27:38, Lei Zhang wrote:
> > > Shouldn't this be part of a larger CL?
> > 
> > I don't know -- do the trybots use the script from the CL itself, or do they
> > keep their own copy they sync periodically?
> 
> From the CL itself. Otherwise you get all kinds of chicken and egg problems.
> 
> > I wanted to do it separately to avoid pulling even more people to work on
the
> CL
> > that's already pretty large and difficult to work with. If you think I
should
> do
> > it in a single CL, let me know.
> 
> It's one more file and 1 more reviewer. If that's too much, at least reference
> the CL that depends on this CL for context.

Here's the CL: https://codereview.chromium.org/1842653006/. Should I add the
change over there?

[Lei Zhang, 2016-04-18 21:25:21]

If you don't mind, just tack it onto the other CL and land it all in one shot.
Happy to review on the other CL.

https://codereview.chromium.org/1893333005/diff/1/tools/checklicenses/checkli...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/1893333005/diff/1/tools/checklicenses/checkli...
tools/checklicenses/checklicenses.py:482: 'MIT/X11 (BSD like) Public domain
MIT/X11 (BSD like)',
Oh geez, because of the amalgamation in jsoncpp.cpp, this is licensecheck.pl
trying to say: "MIT, Public domain, MIT".

Please add a comment to reference https://crbug.com/604499

[Paweł Hajdan Jr., 2016-04-19 09:24:28]

LGTM

Please just add this to WHITELISTED_LICENSES instead. It's always OK, whereas
the path-specific exceptions are intended to be temporary.

[xyzzyz, 2016-04-19 18:40:55]

The CQ bit was checked by xyzzyz@chromium.org

[xyzzyz, 2016-04-19 18:40:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1893333005/#ps20001
(title: "add to global whitelist")

[commit-bot: I haz the power, 2016-04-19 18:41:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893333005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893333005/20001

[commit-bot: I haz the power, 2016-04-19 19:28:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:15:01]

Description was changed from

==========
Add license to checklicenses.py for protobuf

'third_party/protobuf/conformance/third_party/jsoncpp/jsoncpp.cpp' has
non-whitelisted license 'MIT/X11 (BSD like) Public domain MIT/X11 (BSD like)'

The file is released public domain, or MIT/X11 wherever this is not legally
possible.

BUG=597321
==========

to

==========
Add license to checklicenses.py for protobuf

'third_party/protobuf/conformance/third_party/jsoncpp/jsoncpp.cpp' has
non-whitelisted license 'MIT/X11 (BSD like) Public domain MIT/X11 (BSD like)'

The file is released public domain, or MIT/X11 wherever this is not legally
possible.

BUG=597321

Committed: https://crrev.com/2a79b8edf66ed993190047d4867a3c8fb221ceaa
Cr-Commit-Position: refs/heads/master@{#388276}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:02]

Patchset 2 (id:??) landed as
https://crrev.com/2a79b8edf66ed993190047d4867a3c8fb221ceaa
Cr-Commit-Position: refs/heads/master@{#388276}