Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1893193002: Split AlphaThresholdEffect out into its own file (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split AlphaThresholdEffect out into its own file Mainly mechanical although I did: convert Create method to sk_sp Make version rm extra '\t's and '\n's in emitCode TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893193002 Committed: https://skia.googlesource.com/skia/+/f7142e71d7c0a7d8406679e207ff766085499d2e

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -204 lines) Patch
M gyp/effects.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/effects/SkAlphaThresholdFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
A src/effects/GrAlphaThresholdFragmentProcessor.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/effects/GrAlphaThresholdFragmentProcessor.cpp View 1 chunk +175 lines, -0 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 3 chunks +5 lines, -203 lines 0 comments Download
M tests/FlattenableFactoryToName.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
robertphillips
4 years, 8 months ago (2016-04-17 22:39:27 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893193002/1
4 years, 8 months ago (2016-04-17 22:41:47 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/7899)
4 years, 8 months ago (2016-04-17 22:43:18 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893193002/20001
4 years, 8 months ago (2016-04-17 22:52:57 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-17 23:02:35 UTC) #14
jvanverth1
lgtm
4 years, 8 months ago (2016-04-18 12:52:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893193002/20001
4 years, 8 months ago (2016-04-18 14:19:10 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 14:20:09 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f7142e71d7c0a7d8406679e207ff766085499d2e

Powered by Google App Engine
This is Rietveld 408576698