Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1893133002: Add requireHWAA param to GrPipelineBuilder constructor (Closed)

Created:
4 years, 8 months ago by Chris Dalton
Modified:
4 years, 8 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload_create_data
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add requireHWAA param to GrPipelineBuilder constructor This makes it easier to enable HW antialias for things like mixed samples. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893133002

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/gpu/GrPipelineBuilder.h View 1 chunk +4 lines, -2 lines 1 comment Download
M src/gpu/GrPipelineBuilder.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 4 chunks +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1877073002 Patch 20001

Dependent Patchsets:

Issue 1897203002 Patch 1
Issue 1897203002 Patch 20001

Messages

Total messages: 6 (3 generated)
Chris Dalton
4 years, 8 months ago (2016-04-16 21:52:09 UTC) #3
bsalomon
https://codereview.chromium.org/1893133002/diff/20001/src/gpu/GrPipelineBuilder.h File src/gpu/GrPipelineBuilder.h (left): https://codereview.chromium.org/1893133002/diff/20001/src/gpu/GrPipelineBuilder.h#oldcode40 src/gpu/GrPipelineBuilder.h:40: GrPipelineBuilder(const GrPaint&, GrRenderTarget*, const GrClip&); I'm thinking that the ...
4 years, 8 months ago (2016-04-19 14:57:40 UTC) #4
Chris Dalton
4 years, 8 months ago (2016-04-20 08:31:52 UTC) #5 
On 2016/04/19 14:57:40, bsalomon wrote:
>
https://codereview.chromium.org/1893133002/diff/20001/src/gpu/GrPipelineBuild...
> File src/gpu/GrPipelineBuilder.h (left):
> 
>
https://codereview.chromium.org/1893133002/diff/20001/src/gpu/GrPipelineBuild...
> src/gpu/GrPipelineBuilder.h:40: GrPipelineBuilder(const GrPaint&,
> GrRenderTarget*, const GrClip&);
> I'm thinking that the GrPB should completely ignore the GrP's aa setting.
GrP's
> aa setting really means "should the geometry be antialiased" (I'd consider
> taking it off of GrP and making it an explicit param to GrDrawContext's
> methods). GrPB's aa setting means "enable msaa". These are only loosely
related
> and it seems like any inference from GrP's setting to GrPB's setting is better
> handled in the geometry-specific rendering code.

Agreed. I can solve the AA problem differently.

Powered by Google App Engine
This is Rietveld 408576698