Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1877073002: Add optional data parameter to createBuffer (Closed)

Created:
4 years, 8 months ago by Chris Dalton
Modified:
4 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M src/gpu/GrGpu.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 2 chunks +8 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +11 lines, -5 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1893133002 Patch 20001

Messages

Total messages: 8 (4 generated)
Chris Dalton
More bikeshedding
4 years, 8 months ago (2016-04-11 23:11:44 UTC) #3
bsalomon
lgtm
4 years, 8 months ago (2016-04-19 14:53:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877073002/20001
4 years, 8 months ago (2016-04-19 16:50:48 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 17:00:05 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1bf3e71ad06a318613ccc09e1cf47d3c2465b23c

Powered by Google App Engine
This is Rietveld 408576698