Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1892813002: [css-grid] Floated grid containers have indefinite width (Closed)

Created:
4 years, 8 months ago by Manuel Rego
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Floated grid containers have indefinite width Fix LayoutBox::hasDefiniteLogicalWidth() to return FALSE for floated grid containers with auto width. This makes that percentage tracks are treated as "auto" for floated grid containers with indefinite width. BUG=603854 TEST=fast/css-grid-layout/floated-grid-container-percentage-tracks.html Committed: https://crrev.com/a7f443f6a36a2a524c4c29a2ef1bb6d02249d7b2 Cr-Commit-Position: refs/heads/master@{#388054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
A + third_party/WebKit/LayoutTests/fast/css-grid-layout/floated-grid-container-percentage-tracks.html View 4 chunks +13 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Manuel Rego
4 years, 8 months ago (2016-04-15 12:06:24 UTC) #2
cbiesinger
lgtm
4 years, 8 months ago (2016-04-15 18:40:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892813002/1
4 years, 8 months ago (2016-04-18 20:14:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 22:31:04 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a7f443f6a36a2a524c4c29a2ef1bb6d02249d7b2 Cr-Commit-Position: refs/heads/master@{#388054}
4 years, 8 months ago (2016-04-18 22:32:45 UTC) #8
Manuel Rego
4 years, 7 months ago (2016-05-05 07:15:44 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1948203004/ by rego@igalia.com.

The reason for reverting is: This is breaking how percentages work in
Flexbox and Grid compared to regular Blocks.

There're some discussion ongoing on the CSS WG to verify
the expected behavior, so we're reverting this for now
until we've a final resolution.

BUG=538513,603854,604346,608783.

Powered by Google App Engine
This is Rietveld 408576698