Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1892813002: [css-grid] Floated grid containers have indefinite width (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/floated-grid-container-percentage-tracks.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 4156 matching lines...) Expand 10 before | Expand all | Expand 10 after
4167 clearAllOverflows(); 4167 clearAllOverflows();
4168 return; 4168 return;
4169 } 4169 }
4170 4170
4171 m_overflow->setLayoutOverflow(noOverflowRect()); 4171 m_overflow->setLayoutOverflow(noOverflowRect());
4172 } 4172 }
4173 4173
4174 static bool logicalWidthIsResolvable(const LayoutBox& layoutBox) 4174 static bool logicalWidthIsResolvable(const LayoutBox& layoutBox)
4175 { 4175 {
4176 const LayoutBox* box = &layoutBox; 4176 const LayoutBox* box = &layoutBox;
4177 while (!box->isLayoutView() && !box->isOutOfFlowPositioned() 4177 while (!box->isLayoutView() && !box->isFloatingOrOutOfFlowPositioned()
4178 && (box->style()->logicalWidth().isAuto() || box->isAnonymousBlock()) 4178 && (box->style()->logicalWidth().isAuto() || box->isAnonymousBlock())
4179 && !box->hasOverrideContainingBlockLogicalWidth()) 4179 && !box->hasOverrideContainingBlockLogicalWidth())
4180 box = box->containingBlock(); 4180 box = box->containingBlock();
4181 4181
4182 if (box->style()->logicalWidth().isFixed()) 4182 if (box->style()->logicalWidth().isFixed())
4183 return true; 4183 return true;
4184 if (box->isLayoutView()) 4184 if (box->isLayoutView())
4185 return true; 4185 return true;
4186 if (box->isOutOfFlowPositioned() && !box->style()->logicalLeft().isAuto() && !box->style()->logicalRight().isAuto()) 4186 if (box->isOutOfFlowPositioned() && !box->style()->logicalLeft().isAuto() && !box->style()->logicalRight().isAuto())
4187 return true; 4187 return true;
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
4737 4737
4738 void LayoutBox::clearPercentHeightDescendants() 4738 void LayoutBox::clearPercentHeightDescendants()
4739 { 4739 {
4740 for (LayoutObject* curr = slowFirstChild(); curr; curr = curr->nextInPreOrde r(this)) { 4740 for (LayoutObject* curr = slowFirstChild(); curr; curr = curr->nextInPreOrde r(this)) {
4741 if (curr->isBox()) 4741 if (curr->isBox())
4742 toLayoutBox(curr)->removeFromPercentHeightContainer(); 4742 toLayoutBox(curr)->removeFromPercentHeightContainer();
4743 } 4743 }
4744 } 4744 }
4745 4745
4746 } // namespace blink 4746 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/floated-grid-container-percentage-tracks.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698