Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1892743005: [DevTools] Support broken UMA metric from M49 frontend. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support broken UMA metric from M49 frontend. This patch mitigates bad message crash due to wrong UMA metric introduced in https://codereview.chromium.org/1520403004. It was reverted later, but was not merged to M49. BUG=603789 Committed: https://crrev.com/92efcfdf8fdbdb17af835a889ed6ee5bed729bca Cr-Commit-Position: refs/heads/master@{#387793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/devtools.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dgozman
Take a look please.
4 years, 8 months ago (2016-04-16 00:15:16 UTC) #2
caseq
lgtm
4 years, 8 months ago (2016-04-16 00:34:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892743005/1
4 years, 8 months ago (2016-04-16 00:34:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 02:23:03 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 02:25:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92efcfdf8fdbdb17af835a889ed6ee5bed729bca
Cr-Commit-Position: refs/heads/master@{#387793}

Powered by Google App Engine
This is Rietveld 408576698