Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1520403004: Devtools: Add metrics for drawer views being shown (Closed)

Created:
5 years ago by samli
Modified:
4 years, 10 months ago
Reviewers:
Steven Holte, pfeldman
CC:
apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Add metrics for drawer views being shown Given that drawer views are taking an increasingly dominant UI position, broad metric should be added like panels shown. Committed: https://crrev.com/d4bebfb49bc2fad42b8b1a1bf92ade6a17377a25 Cr-Commit-Position: refs/heads/master@{#367455}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Drawer.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js View 1 2 chunks +19 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +16 lines, -2 lines 2 comments Download

Messages

Total messages: 17 (6 generated)
samli
5 years ago (2015-12-15 06:55:11 UTC) #2
pfeldman
lgtm
4 years, 11 months ago (2016-01-04 21:42:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520403004/20001
4 years, 11 months ago (2016-01-05 00:06:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/132389)
4 years, 11 months ago (2016-01-05 00:17:00 UTC) #7
samli
+holte: ptal at histograms.xml
4 years, 11 months ago (2016-01-05 00:21:25 UTC) #9
Steven Holte
lgtm https://codereview.chromium.org/1520403004/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1520403004/diff/20001/tools/metrics/histograms/histograms.xml#oldcode6857 tools/metrics/histograms/histograms.xml:6857: - <owner>vsevik@chromium.org</owner> Is this removal related?
4 years, 11 months ago (2016-01-05 01:24:09 UTC) #10
samli
https://codereview.chromium.org/1520403004/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1520403004/diff/20001/tools/metrics/histograms/histograms.xml#oldcode6857 tools/metrics/histograms/histograms.xml:6857: - <owner>vsevik@chromium.org</owner> On 2016/01/05 at 01:24:09, Steven Holte wrote: ...
4 years, 11 months ago (2016-01-05 01:38:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520403004/20001
4 years, 11 months ago (2016-01-05 01:39:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 01:44:37 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d4bebfb49bc2fad42b8b1a1bf92ade6a17377a25 Cr-Commit-Position: refs/heads/master@{#367455}
4 years, 11 months ago (2016-01-05 01:45:28 UTC) #16
kozy
4 years, 10 months ago (2016-02-06 00:43:44 UTC) #17
Message was sent while issue was closed.
On 2016/01/05 01:45:28, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/d4bebfb49bc2fad42b8b1a1bf92ade6a17377a25
> Cr-Commit-Position: refs/heads/master@{#367455}

CL was reverted manually in https://codereview.chromium.org/1672243003/

Powered by Google App Engine
This is Rietveld 408576698