Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1892743002:
Fix querySelectorAll for multiple Ids in a shadow tree (Closed)
|
Created:
4 years, 8 months ago by hayato Modified:
4 years, 8 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix querySelectorAll for multiple Ids in a shadow tree
One of the code paths in the selector query code looks up IDs in the document scope
instead of the tree-scope for the shadow tree when querying inside a shadow tree.
This CL is separated CL from https://codereview.chromium.org/1883083002
BUG=603431
Committed: https://crrev.com/9f363d853d714ebd13fb0abb951cddc83451912a
Cr-Commit-Position: refs/heads/master@{#387561}
Patch Set 1 #Patch Set 2 : wip #Patch Set 3 : wip #
Total comments: 2
Patch Set 4 : done #
Messages
Total messages: 26 (13 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892743002/1
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
wip
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892743002/20001
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
wip
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892743002/40001
Description was changed from ========== Fix a querySelector for multiple ids in a shadow tree BUG=603431 ========== to ========== Fix a querySelectorAll for multiple Ids in a shadow tree One of the code paths in the selector query code looks up IDs in the document scope instead of the tree-scope for the shadow tree when querying inside a shadow tree. BUG=603431 ==========
Description was changed from ========== Fix a querySelectorAll for multiple Ids in a shadow tree One of the code paths in the selector query code looks up IDs in the document scope instead of the tree-scope for the shadow tree when querying inside a shadow tree. BUG=603431 ========== to ========== Fix querySelectorAll for multiple Ids in a shadow tree One of the code paths in the selector query code looks up IDs in the document scope instead of the tree-scope for the shadow tree when querying inside a shadow tree. BUG=603431 ==========
Description was changed from ========== Fix querySelectorAll for multiple Ids in a shadow tree One of the code paths in the selector query code looks up IDs in the document scope instead of the tree-scope for the shadow tree when querying inside a shadow tree. BUG=603431 ========== to ========== Fix querySelectorAll for multiple Ids in a shadow tree One of the code paths in the selector query code looks up IDs in the document scope instead of the tree-scope for the shadow tree when querying inside a shadow tree. This CL is separated CL from https://codereview.chromium.org/1883083002 BUG=603431 ==========
hayato@chromium.org changed reviewers: + kochi@chromium.org, rune@opera.com
PTAL
lgtm https://codereview.chromium.org/1892743002/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/shadow-dom/query-selector.html (right): https://codereview.chromium.org/1892743002/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/query-selector.html:23: }, "querySelectorAll for multiple #Ids in a shadow tree"); style nit: consistent usage of single and double quotes in HTML/JavaScript? (e.g. double quote for HTML, single quote for JS?)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
done
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892743002/60001
https://codereview.chromium.org/1892743002/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/shadow-dom/query-selector.html (right): https://codereview.chromium.org/1892743002/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/query-selector.html:23: }, "querySelectorAll for multiple #Ids in a shadow tree"); Done. Made it consistent.
The CQ bit was unchecked by hayato@chromium.org
The CQ bit was checked by hayato@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org Link to the patchset: https://codereview.chromium.org/1892743002/#ps60001 (title: "done")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892743002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
Message was sent while issue was closed.
Description was changed from ========== Fix querySelectorAll for multiple Ids in a shadow tree One of the code paths in the selector query code looks up IDs in the document scope instead of the tree-scope for the shadow tree when querying inside a shadow tree. This CL is separated CL from https://codereview.chromium.org/1883083002 BUG=603431 ========== to ========== Fix querySelectorAll for multiple Ids in a shadow tree One of the code paths in the selector query code looks up IDs in the document scope instead of the tree-scope for the shadow tree when querying inside a shadow tree. This CL is separated CL from https://codereview.chromium.org/1883083002 BUG=603431 Committed: https://crrev.com/9f363d853d714ebd13fb0abb951cddc83451912a Cr-Commit-Position: refs/heads/master@{#387561} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/9f363d853d714ebd13fb0abb951cddc83451912a Cr-Commit-Position: refs/heads/master@{#387561} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
