third_party/WebKit/LayoutTests/shadow-dom/query-selector.html - Issue 1892743002: Fix querySelectorAll for multiple Ids in a shadow tree

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/shadow-dom/query-selector.html

Issue 1892743002: Fix querySelectorAll for multiple Ids in a shadow tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src='../resources/testharness.js'></script>

	3 <script src='../resources/testharnessreport.js'></script>

	4 <script src="resources/shadow-dom.js"></script>

	5 <div id="x"><span></span></div>

	6 <div id="x"><span></span></div>

	7 <div id="host">

	8 <template data-mode='open'>

	9 <div id="y"><span></span></div>

	10 <div id="y"><span></span></div>

	11 </template>

	12 </div>

	13 <script>

	14 convertTemplatesToShadowRootsWithin(host);

	15 test(() => {

	16 assert_equals(document.querySelectorAll('#x').length, 2);

	17 assert_equals(document.querySelectorAll('#x span').length, 2);

	18 }, "querySelectorAll for multiple #Ids in a document tree");

	19

	20 test(() => {

	21 assert_equals(host.shadowRoot.querySelectorAll('#y').length, 2);

	22 assert_equals(host.shadowRoot.querySelectorAll('#y span').length, 2);

	23 }, "querySelectorAll for multiple #Ids in a shadow tree");
	kochi 2016/04/15 05:31:25 style nit: consistent usage of single and double q style nit: consistent usage of single and double quotes in HTML/JavaScript? (e.g. double quote for HTML, single quote for JS?) hayato 2016/04/15 05:34:06 Done. Made it consistent. Done. Made it consistent.
	24 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »