Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 189263017: Clean up outdated gpu driver bug workarounds for Mac 10.9 (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Clean up outdated gpu driver bug workarounds for Mac 10.9 Tested with NVIDIA, AMD, Intel HD 3000/4000 Actually I also tested with 10.8.5, but at this point I don't think it's worth making any changes on 10.8.5. BUG=349137 TEST= R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255833

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : updates #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -39 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 3 8 chunks +56 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Zhenyao Mo
kbr: please take a look. I think moving forward, we should shake off mud a ...
6 years, 9 months ago (2014-03-07 23:19:58 UTC) #1
Ken Russell (switch to Gerrit)
LGTM https://codereview.chromium.org/189263017/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/189263017/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode55 gpu/config/gpu_driver_bug_list_json.cc:55: "cr_bugs": [349137], Is this really the right bug ...
6 years, 9 months ago (2014-03-07 23:34:13 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/189263017/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/189263017/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode55 gpu/config/gpu_driver_bug_list_json.cc:55: "cr_bugs": [349137], On 2014/03/07 23:34:13, Ken Russell wrote: > ...
6 years, 9 months ago (2014-03-07 23:40:24 UTC) #3
Ken Russell (switch to Gerrit)
Still LGTM. Thanks for digging up the old bug IDs. Please send this through the ...
6 years, 9 months ago (2014-03-08 01:22:17 UTC) #4
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 9 months ago (2014-03-08 01:23:51 UTC) #5
Zhenyao Mo
The CQ bit was unchecked by zmo@chromium.org
6 years, 9 months ago (2014-03-08 01:26:54 UTC) #6
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 9 months ago (2014-03-08 01:29:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/189263017/60001
6 years, 9 months ago (2014-03-08 11:17:14 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:00:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234357
6 years, 9 months ago (2014-03-08 14:00:04 UTC) #10
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 9 months ago (2014-03-09 06:55:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/189263017/60001
6 years, 9 months ago (2014-03-09 06:55:21 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 07:09:03 UTC) #13
Message was sent while issue was closed.
Change committed as 255833

Powered by Google App Engine
This is Rietveld 408576698