Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1892493002:
Remove asFragmentProcessor gpu-specific ImageFilter code path (Closed)
|
Created:
4 years, 8 months ago by robertphillips Modified:
4 years, 8 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionRemove asFragmentProcessor gpu-specific ImageFilter code path
No image filter should be using this code path now.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1892493002
Committed: https://skia.googlesource.com/skia/+/938115c9f8a3453ad6f511c0a23dabb46ec5a71f
Patch Set 1 #Patch Set 2 : Remove unused parameters #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== Remove asFragmentProcessor gpu-specific ImageFilter code path ========== to ========== Remove asFragmentProcessor gpu-specific ImageFilter code path GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Remove asFragmentProcessor gpu-specific ImageFilter code path GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Remove asFragmentProcessor gpu-specific ImageFilter code path No image filter should be using this code path now. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + reed@google.com, senorblanco@chromium.org, senorblanco@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping
LGTM \o/
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892493002/20001
Message was sent while issue was closed.
Description was changed from ========== Remove asFragmentProcessor gpu-specific ImageFilter code path No image filter should be using this code path now. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Remove asFragmentProcessor gpu-specific ImageFilter code path No image filter should be using this code path now. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/938115c9f8a3453ad6f511c0a23dabb46ec5a71f ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/938115c9f8a3453ad6f511c0a23dabb46ec5a71f |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
