|
Revert of Compute GpuDriverBugWorkarounds only one time in the GPU process (patchset #16 id:300001 of https://codereview.chromium.org/1871613002/ )
Reason for revert:
This commit breaks the gles2_conform tests on all the GPU FYI Linux and Mac bots, see https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28New%20Intel%29/builds/758/steps/gles2_conform_test/logs/stdio
Original issue's description:
> Compute GpuDriverBugWorkarounds only one time in the GPU process
>
> Previously the extraction of "--gpu-driver-bug-workarounds" from the
> command-line was done in FeatureInfo's constructor. Since a new FeatureInfo
> is created for each ContextGroup this extraction was done again whereas
> the result is constant.
>
> This CL moved owner ship of Workarounds from FeatureInfo to
> InProcessCommandBuffer when running in gpu process mode. But moved
> to GpuChannelManager otherwise.
>
> class GpuDriverBugWorkarounds has been added within new files
> gpu_driver_bug_workarounds.h/.cc.
>
> BUG= 599964
>
> R=kbr@chromium.org, piman@chromium.org, rjkroege@chromium.org, zmo@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/dab49af5278797db0a8374f2a7f06c6c33b8158b
> Cr-Commit-Position: refs/heads/master@{#387569}
TBR=kbr@chromium.org,piman@chromium.org,rjkroege@chromium.org,zmo@chromium.org,ben@chromium.org,cpu@chromium.org,j.isorce@samsung.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 599964
Committed: https://crrev.com/2fcc0be68453b91ac58cfb05e91265d1323ce642
Cr-Commit-Position: refs/heads/master@{#387588}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+153 lines, -268 lines) |
Patch |
|
M |
components/mus/gles2/command_buffer_driver.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
components/mus/gles2/gpu_state.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/mus/gles2/gpu_state.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/buffer_manager_unittest.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/context_group.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/context_group_unittest.cc
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/feature_info.h
|
View
|
|
4 chunks |
+23 lines, -9 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/feature_info.cc
|
View
|
|
3 chunks |
+62 lines, -12 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/feature_info_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
|
View
|
|
1 chunk |
+9 lines, -11 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/in_process_command_buffer.h
|
View
|
|
4 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/in_process_command_buffer.cc
|
View
|
|
2 chunks |
+9 lines, -18 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/texture_manager.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/texture_manager_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/es3_misc_functions_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_clear_framebuffer_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_ext_blend_func_extended_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_manager.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_manager.cc
|
View
|
|
4 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_request_extension_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/tests/gl_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
gpu/config/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
D |
gpu/config/gpu_driver_bug_workarounds.h
|
View
|
|
1 chunk |
+0 lines, -46 lines |
0 comments
|
Download
|
|
D |
gpu/config/gpu_driver_bug_workarounds.cc
|
View
|
|
1 chunk |
+0 lines, -98 lines |
0 comments
|
Download
|
|
M |
gpu/gpu_config.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
gpu/ipc/service/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
gpu/ipc/service/gpu_channel.cc
|
View
|
|
1 chunk |
+9 lines, -2 lines |
0 comments
|
Download
|
|
M |
gpu/ipc/service/gpu_channel_manager.h
|
View
|
|
3 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
gpu/ipc/service/gpu_channel_manager.cc
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
gpu/ipc/service/gpu_command_buffer_stub.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|