content/browser/speech/speech_recognition_manager_impl.cc - Issue 1892483002: Drop support for uploading hardware info with speech recognition requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_manager_impl.cc

Issue 1892483002: Drop support for uploading hardware info with speech recognition requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devirtualize_speechrecognitionengine

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/speech/speech_recognition_engine.cc ('k') | content/public/browser/speech_recognition_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognition_manager_impl.cc

diff --git a/content/browser/speech/speech_recognition_manager_impl.cc b/content/browser/speech/speech_recognition_manager_impl.cc

index 39bfc1a7df74ba82bf226cf4f7e907bf1466e4a7..4dde801825fd163fc9ef01240ee4f6fcf6d2a2c7 100644

--- a/content/browser/speech/speech_recognition_manager_impl.cc

+++ b/content/browser/speech/speech_recognition_manager_impl.cc

@@ -106,11 +106,6 @@ int SpeechRecognitionManagerImpl::CreateSession(

session->config = config;

session->context = config.initial_context;

- std::string hardware_info;

- bool can_report_metrics = false;

- if (delegate_)

- delegate_->GetDiagnosticInformation(&can_report_metrics, &hardware_info);

#if !defined(OS_ANDROID)

// A SpeechRecognitionEngine (and corresponding Config) is required only

// when using SpeechRecognizerImpl, which performs the audio capture and

@@ -130,7 +125,6 @@ int SpeechRecognitionManagerImpl::CreateSession(

remote_engine_config.continuous = config.continuous;

remote_engine_config.interim_results = config.interim_results;

remote_engine_config.max_hypotheses = config.max_hypotheses;

- remote_engine_config.hardware_info = hardware_info;

remote_engine_config.origin_url = config.origin_url;

remote_engine_config.auth_token = config.auth_token;

remote_engine_config.auth_scope = config.auth_scope;