content/browser/speech/speech_recognition_engine.cc - Issue 1892483002: Drop support for uploading hardware info with speech recognition requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_engine.cc

Issue 1892483002: Drop support for uploading hardware info with speech recognition requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devirtualize_speechrecognitionengine

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/speech/speech_recognition_engine.h ('k') | content/browser/speech/speech_recognition_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognition_engine.cc

diff --git a/content/browser/speech/speech_recognition_engine.cc b/content/browser/speech/speech_recognition_engine.cc

index b0fac7db62feb1ea375d7c2772dd53e7ec85d8c3..071e655c5d0bbb5e2f862c79b8f6bc5ca4a371fa 100644

--- a/content/browser/speech/speech_recognition_engine.cc

+++ b/content/browser/speech/speech_recognition_engine.cc

@@ -362,10 +362,6 @@ SpeechRecognitionEngine::ConnectBothStreams(const FSMEventArgs&) {

base::UintToString(max_alternatives));

}

upstream_args.push_back("app=chromium");

- if (!config_.hardware_info.empty()) {

- upstream_args.push_back(

- "xhw=" + net::EscapeQueryParamValue(config_.hardware_info, true));

- }

for (const SpeechRecognitionGrammar& grammar : config_.grammars) {

std::string grammar_value(

base::DoubleToString(grammar.weight) + ":" + grammar.url);

« no previous file with comments | « content/browser/speech/speech_recognition_engine.h ('k') | content/browser/speech/speech_recognition_manager_impl.cc » ('j') | no next file with comments »