tools/gn/target_generator.cc - Issue 1892393002: 🐜 GN: Make write_runtime_deps take effect only a target is resolved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target_generator.cc

Issue 1892393002: 🐜 GN: Make write_runtime_deps take effect only a target is resolved (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/target_generator.cc

diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc

index 2132a5b06bdca2565ce9e04c2aa8d2bf05f12ab1..90642d47d201b36895f3c0693807e9befa5acec1 100644

--- a/tools/gn/target_generator.cc

+++ b/tools/gn/target_generator.cc

@@ -403,6 +403,5 @@ bool TargetGenerator::FillWriteRuntimeDeps() {

OutputFile output_file(GetBuildSettings(), source_file);

target_->set_write_runtime_deps_output(output_file);

- g_scheduler->AddWriteRuntimeDepsTarget(target_);

return true;

}

« no previous file with comments | « tools/gn/target.cc ('k') | tools/gn/test_with_scope.h » ('j') | no next file with comments »