tools/gn/target_generator.cc - Issue 1892393002: 🐜 GN: Make write_runtime_deps take effect only a target is resolved

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/target_generator.cc

Issue 1892393002: 🐜 GN: Make write_runtime_deps take effect only a target is resolved (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/gn/target.cc ('k') | tools/gn/test_with_scope.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "tools/gn/target_generator.h"	5 #include "tools/gn/target_generator.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include "tools/gn/action_target_generator.h"	9 #include "tools/gn/action_target_generator.h"

10 #include "tools/gn/binary_target_generator.h"	10 #include "tools/gn/binary_target_generator.h"

(...skipping 385 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
396 SourceFile source_file = scope_->GetSourceDir().ResolveRelativeFile(	396 SourceFile source_file = scope_->GetSourceDir().ResolveRelativeFile(

397 *value, err_, GetBuildSettings()->root_path_utf8());	397 *value, err_, GetBuildSettings()->root_path_utf8());

398 if (err_->has_error())	398 if (err_->has_error())

399 return false;	399 return false;

400 if (!EnsureStringIsInOutputDir(GetBuildSettings()->build_dir(),	400 if (!EnsureStringIsInOutputDir(GetBuildSettings()->build_dir(),

401 source_file.value(), value->origin(), err_))	401 source_file.value(), value->origin(), err_))

402 return false;	402 return false;

403 OutputFile output_file(GetBuildSettings(), source_file);	403 OutputFile output_file(GetBuildSettings(), source_file);

404 target_->set_write_runtime_deps_output(output_file);	404 target_->set_write_runtime_deps_output(output_file);

405	405

406 g_scheduler->AddWriteRuntimeDepsTarget(target_);

407 return true;	406 return true;

408 }	407 }

OLD	NEW