Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1892213002: Add shell=True for gn-format.py on Windows (Closed)

Created:
4 years, 8 months ago by scottmg
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add shell=True for gn-format.py on Windows Broken if gn.exe isn't in path (which it isn't if you're using the depot_tools wrapper goop.) Committed: https://crrev.com/3a93fa5a544dc594288a725b34e6ecda8c718802 Cr-Commit-Position: refs/heads/master@{#387689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/bin/gn-format.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
scottmg
4 years, 8 months ago (2016-04-15 19:33:57 UTC) #3
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-15 20:00:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892213002/1
4 years, 8 months ago (2016-04-15 20:08:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 20:13:27 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 20:15:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a93fa5a544dc594288a725b34e6ecda8c718802
Cr-Commit-Position: refs/heads/master@{#387689}

Powered by Google App Engine
This is Rietveld 408576698