tools/gn/bin/gn-format.py - Issue 1892213002: Add shell=True for gn-format.py on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/bin/gn-format.py

Issue 1892213002: Add shell=True for gn-format.py on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/bin/gn-format.py

diff --git a/tools/gn/bin/gn-format.py b/tools/gn/bin/gn-format.py

index c835753eefbdb894a02254994195e18dc9a3a1ff..4769640297f77e244ef868704213300275b399e4 100644

--- a/tools/gn/bin/gn-format.py

+++ b/tools/gn/bin/gn-format.py

@@ -38,7 +38,7 @@ def main():

p = subprocess.Popen([binary, 'format', '--stdin'],

stdout=subprocess.PIPE, stderr=subprocess.PIPE,

stdin=subprocess.PIPE, startupinfo=startupinfo,

- universal_newlines=True)

+ shell=True, universal_newlines=True)

stdout, stderr = p.communicate(input=text)

if p.returncode != 0:

print 'Formatting failed, please report to gn-dev@chromium.org.'

« no previous file with comments | « no previous file | no next file » | no next file with comments »