Add base::IsOnNetworkDrive.

Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
TEST=http://pastebin.com/raw/jNUNwiQe

Committed: https://crrev.com/2396e07db179be4f5a22ab2acc1503d0cdb1e499
Cr-Commit-Position: refs/heads/master@{#387981}

[Will Harris, 2016-04-15 23:31:20]

Description was changed from

==========
Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
==========

to

==========
Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
==========

[Will Harris, 2016-04-15 23:31:20]

wfh@chromium.org changed reviewers:
+ cpu@chromium.org, thestig@chromium.org

[Will Harris, 2016-04-15 23:39:41]

Patchset #2 (id:20001) has been deleted

[Will Harris, 2016-04-15 23:40:57]

Description was changed from

==========
Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
==========

to

==========
Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
TEST=http://pastebin.com/raw/jNUNwiQe
==========

[Will Harris, 2016-04-15 23:42:19]

changes made as per code review in other CL. PTAL

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util.h
File base/files/file_util.h (right):

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util.h#...
base/files/file_util.h:293: // drive or not. If |path| does not exist, this
function returns false.
added comment about path not existing.

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util_un...
File base/files/file_util_unittest.cc (right):

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util_un...
base/files/file_util_unittest.cc:1695: // To test IsOnNetworkDrive() for remote
cases, set up a file server
added environment variables for testing network share

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util_wi...
File base/files/file_util_win.cc (right):

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util_wi...
base/files/file_util_win.cc:565: GENERIC_READ,
added GENERIC_READ to be explicit

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util_wi...
base/files/file_util_win.cc:566: kFileShareAll,
using kFileShareAll like other tests.

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util_wi...
base/files/file_util_win.cc:577: return
!!::GetFileInformationByHandleEx(handle.Get(), FileRemoteProtocolInfo,
returns straight

[Will Harris, 2016-04-15 23:51:09]

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util_un...
File base/files/file_util_unittest.cc (right):

https://codereview.chromium.org/1892153003/diff/40001/base/files/file_util_un...
base/files/file_util_unittest.cc:1724: full_path =
base::StringPrintf(test_case.input, network_server.c_str(),
in retrospect I should probably just use ExpandEnvironmentStrings here. I'll
upload a new CL soon.

[Will Harris, 2016-04-16 00:09:03]

On 2016/04/15 23:51:09, Will Harris wrote:
> in retrospect I should probably just use ExpandEnvironmentStrings here. I'll
> upload a new CL soon.

Now using ExpandEnvironmentStrings and ready for another look. Thanks!

[cpu_(ooo_6.6-7.5), 2016-04-18 18:00:23]

lgtm

[Will Harris, 2016-04-18 18:01:37]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-04-18 18:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1892153003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1892153003/60001

[commit-bot: I haz the power, 2016-04-18 19:17:32]

Description was changed from

==========
Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
TEST=http://pastebin.com/raw/jNUNwiQe
==========

to

==========
Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
TEST=http://pastebin.com/raw/jNUNwiQe
==========

[commit-bot: I haz the power, 2016-04-18 19:17:33]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-18 19:19:09]

Description was changed from

==========
Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
TEST=http://pastebin.com/raw/jNUNwiQe
==========

to

==========
Add base::IsOnNetworkDrive.

BUG=572131
TEST=base_unittests
TEST=http://pastebin.com/raw/jNUNwiQe

Committed: https://crrev.com/2396e07db179be4f5a22ab2acc1503d0cdb1e499
Cr-Commit-Position: refs/heads/master@{#387981}
==========

[commit-bot: I haz the power, 2016-04-18 19:19:11]

Patchset 3 (id:??) landed as
https://crrev.com/2396e07db179be4f5a22ab2acc1503d0cdb1e499
Cr-Commit-Position: refs/heads/master@{#387981}