Add base::IsOnNetworkDrive.

base/files/file_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <fstream>
 #include <set>
 #include <utility>
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_file.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_file_util.h"
 #include "base/threading/platform_thread.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
 #include <tchar.h>
 #include <winioctl.h>
+#include "base/environment.h"
 #include "base/win/scoped_handle.h"
 #include "base/win/windows_version.h"
 #endif
 
 #if defined(OS_POSIX)
 #include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>
 #endif
 
@@ skipping 1611 matching lines @@
   }
 
   // Restore the original $TMP.
   if (original_tmp) {
     ::_tputenv_s(kTmpKey, original_tmp);
     free(original_tmp);
   } else {
     ::_tputenv_s(kTmpKey, _T(""));
   }
 }
+
+TEST_F(FileUtilTest, IsOnNetworkDrive) {
+  struct LocalTestData {
+    const FilePath::CharType* input;
+    bool expected;
+  };
+
+  const LocalTestData local_cases[] = {
+    { FPL(""),                               false },
+    { FPL("c:\\"),                           false },
+    { FPL("c:"),                             false },
+    { FPL("c:\\windows\\notepad.exe"),       false }
+  };
+
+  for (const auto& test_case : local_cases) {
+    FilePath input(test_case.input);
+    bool observed = IsOnNetworkDrive(input);
+    EXPECT_EQ(test_case.expected, observed) << " input: " << input.value();
+  }
+
+  Environment* env = Environment::Create();
+  ASSERT_TRUE(!!env);
+
+  std::string network_server;
+  std::string network_share;
+
+  // To test IsOnNetworkDrive() for remote cases, set up a file server

[Will Harris, 2016/04/15 23:42:19]

added environment variables for testing network share

+  // and place a file called file.txt on the server e.g.
+  // \\DC01\TESTSHARE\file.txt
+  // then set the two environment variables:
+  // set BASE_TEST_FILE_SERVER=DC01
+  // set BASE_TEST_FILE_SHARE=TESTSHARE
+  if (!env->GetVar("BASE_TEST_FILE_SERVER", &network_server) ||
+      !env->GetVar("BASE_TEST_FILE_SHARE", &network_share)) {
+    return;
+  }
+
+  struct NetworkTestData {
+    const char* input;
+    bool format_string_both;
+    bool expected;
+  };
+
+  const NetworkTestData network_cases[] = {
+    { "\\\\%hs",                 false, false },
+    { "\\\\%hs\\",               false, false },
+    { "\\\\%hs\\file.txt",       false, false },
+    { "\\\\%hs\\%hs",            true,  true },
+    { "\\\\%hs\\%hs\\",          true,  true },
+    { "\\\\%hs\\%hs\\file.txt",  true,  true }
+  };
+
+  for (const auto& test_case : network_cases) {
+    std::string full_path;
+    if (test_case.format_string_both) {
+      full_path = base::StringPrintf(test_case.input, network_server.c_str(),

[Will Harris, 2016/04/15 23:51:08]

in retrospect I should probably just use ExpandEnvironmentStrings here. I'll
upload a new CL soon.

+                                     network_share.c_str());
+    } else {
+      full_path = base::StringPrintf(test_case.input, network_server.c_str());
+    }
+    FilePath input(base::UTF8ToUTF16(full_path));
+    EXPECT_EQ(test_case.expected, IsOnNetworkDrive(input)) << " input : "
+                                                           << input.value();
+  }
+}
 #endif  // OS_WIN
 
 TEST_F(FileUtilTest, CreateTemporaryFileTest) {
   FilePath temp_files[3];
   for (int i = 0; i < 3; i++) {
     ASSERT_TRUE(CreateTemporaryFile(&(temp_files[i])));
     EXPECT_TRUE(PathExists(temp_files[i]));
     EXPECT_FALSE(DirectoryExists(temp_files[i]));
   }
   for (int i = 0; i < 3; i++)
@@ skipping 843 matching lines @@
   // Trying to close it should crash. This is important for security.
   EXPECT_DEATH(CloseWithScopedFD(fds[1]), "");
 #endif
 }
 
 #endif  // defined(OS_POSIX)
 
 }  // namespace
 
 }  // namespace base