Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1892143003: Prevent a potential OOB read in TranslateImageLine. (Closed)

Created:
3 years, 3 months ago by Oliver Chang
Modified:
3 years, 3 months ago
Reviewers:
Tom Sepez
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Prevent a potential OOB read in TranslateImageLine. Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and its CPDF_ColorSpace, from code attempting to recover from a failed decoder initialisation in CPDF_DIBSource::CreateDecoder. BUG=chromium:603518 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7cf555202756c51ce2b5ae18efdeb6e1bb6a9e41

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 1 chunk +6 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
A testing/resources/bug_603518.pdf View Binary file 0 comments Download

Messages

Total messages: 12 (7 generated)
Oliver Chang
Tom, for review.
3 years, 3 months ago (2016-04-15 19:18:29 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp File core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right): https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp#newcode578 core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:578: if (m_Family == PDFCS_LAB && m_nComponents != 3) ...
3 years, 3 months ago (2016-04-15 20:14:49 UTC) #6
Oliver Chang
https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp File core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right): https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp#newcode578 core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:578: if (m_Family == PDFCS_LAB && m_nComponents != 3) { ...
3 years, 3 months ago (2016-04-15 20:40:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892143003/20001
3 years, 3 months ago (2016-04-15 20:40:46 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2016-04-15 20:52:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7cf555202756c51ce2b5ae18efdeb6e1bb6a...

Powered by Google App Engine
This is Rietveld 408576698