Prevent a potential OOB read in TranslateImageLine.

Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a failed decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=chromium:603518
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/7cf555202756c51ce2b5ae18efdeb6e1bb6a9e41

[Oliver Chang, 2016-04-15 19:16:37]

Description was changed from

==========
Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=603518
==========

to

==========
Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=chromium:603518
==========

[Oliver Chang, 2016-04-15 19:18:02]

Description was changed from

==========
Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=chromium:603518
==========

to

==========
Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=chromium:603518
R=tsepez@chromium.org
==========

[Oliver Chang, 2016-04-15 19:18:02]

ochang@chromium.org changed reviewers:
+ tsepez@chromium.org

[Oliver Chang, 2016-04-15 19:18:29]

Tom, for review.

[Oliver Chang, 2016-04-15 19:19:08]

Description was changed from

==========
Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=chromium:603518
R=tsepez@chromium.org
==========

to

==========
Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a failed decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=chromium:603518
R=tsepez@chromium.org
==========

[Tom Sepez, 2016-04-15 20:14:49]

lgtm

https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fp...
File core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:578: if (m_Family ==
PDFCS_LAB && m_nComponents != 3) {
nit: no {}

https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:582: if (!m_pCompData) {
here too

[Oliver Chang, 2016-04-15 20:40:26]

https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fp...
File core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:578: if (m_Family ==
PDFCS_LAB && m_nComponents != 3) {
On 2016/04/15 20:14:49, Tom Sepez wrote:
> nit: no {}

Done.

https://codereview.chromium.org/1892143003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:582: if (!m_pCompData) {
On 2016/04/15 20:14:49, Tom Sepez wrote:
> here too

Done.

[Oliver Chang, 2016-04-15 20:40:39]

The CQ bit was checked by ochang@chromium.org

[Oliver Chang, 2016-04-15 20:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1892143003/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-04-15 20:40:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1892143003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1892143003/20001

[commit-bot: I haz the power, 2016-04-15 20:52:02]

Description was changed from

==========
Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a failed decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=chromium:603518
R=tsepez@chromium.org
==========

to

==========
Prevent a potential OOB read in TranslateImageLine.

Fixes a potential mismatch of |m_nComponents| between CPDF_DIBSource and
its CPDF_ColorSpace, from code attempting to recover from a failed decoder
initialisation in CPDF_DIBSource::CreateDecoder.

BUG=chromium:603518
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/7cf555202756c51ce2b5ae18efdeb6e1bb6a...
==========

[commit-bot: I haz the power, 2016-04-15 20:52:03]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7cf555202756c51ce2b5ae18efdeb6e1bb6a...