Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: core/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp

Issue 1892143003: Prevent a potential OOB read in TranslateImageLine. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp ('k') | testing/resources/bug_603518.pdf » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "testing/embedder_test.h" 5 #include "testing/embedder_test.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 7
8 class FPDFRenderLoadImageEmbeddertest : public EmbedderTest {}; 8 class FPDFRenderLoadImageEmbeddertest : public EmbedderTest {};
9 9
10 TEST_F(FPDFRenderLoadImageEmbeddertest, Bug_554151) { 10 TEST_F(FPDFRenderLoadImageEmbeddertest, Bug_554151) {
11 // Test scanline downsampling with a BitsPerComponent of 4. 11 // Test scanline downsampling with a BitsPerComponent of 4.
12 // Should not crash. 12 // Should not crash.
13 EXPECT_TRUE(OpenDocument("bug_554151.pdf")); 13 EXPECT_TRUE(OpenDocument("bug_554151.pdf"));
14 FPDF_PAGE page = LoadPage(0); 14 FPDF_PAGE page = LoadPage(0);
15 EXPECT_NE(nullptr, page); 15 EXPECT_NE(nullptr, page);
16 FPDF_BITMAP bitmap = RenderPage(page); 16 FPDF_BITMAP bitmap = RenderPage(page);
17 FPDFBitmap_Destroy(bitmap); 17 FPDFBitmap_Destroy(bitmap);
18 UnloadPage(page); 18 UnloadPage(page);
19 } 19 }
20 20
21 TEST_F(FPDFRenderLoadImageEmbeddertest, Bug_557223) { 21 TEST_F(FPDFRenderLoadImageEmbeddertest, Bug_557223) {
22 // Should not crash 22 // Should not crash
23 EXPECT_TRUE(OpenDocument("bug_557223.pdf")); 23 EXPECT_TRUE(OpenDocument("bug_557223.pdf"));
24 FPDF_PAGE page = LoadPage(0); 24 FPDF_PAGE page = LoadPage(0);
25 EXPECT_NE(nullptr, page); 25 EXPECT_NE(nullptr, page);
26 FPDF_BITMAP bitmap = RenderPage(page); 26 FPDF_BITMAP bitmap = RenderPage(page);
27 FPDFBitmap_Destroy(bitmap); 27 FPDFBitmap_Destroy(bitmap);
28 UnloadPage(page); 28 UnloadPage(page);
29 } 29 }
30
31 TEST_F(FPDFRenderLoadImageEmbeddertest, Bug_603518) {
32 // Should not crash
33 EXPECT_TRUE(OpenDocument("bug_603518.pdf"));
34 FPDF_PAGE page = LoadPage(0);
35 EXPECT_NE(nullptr, page);
36 FPDF_BITMAP bitmap = RenderPage(page);
37 FPDFBitmap_Destroy(bitmap);
38 UnloadPage(page);
39 }
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp ('k') | testing/resources/bug_603518.pdf » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698