Add components/network_session_configurator.

Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator to this component.  Note that
currently command line switches are ignored.  To preserve this behavior,
this CL calls network_session_configurator::ParseFieldTrials() from
IOSChromeIOThread, which also ignores command line switches.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
Committed: https://crrev.com/210d6f3dc4f72563db1ba760dd1a2e53fd3822ef
Cr-Commit-Position: refs/heads/master@{#395540}

[Bence, 2016-04-18 18:10:59]

Description was changed from

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator there.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread into
//components, so that a follow-up CL can make IOSChromeIOThread depend on it.

BUG=586616
==========

to

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator there.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
==========

[Bence, 2016-04-21 11:31:11]

Description was changed from

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator there.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
==========

to

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator to this component.  Note that when
called from iOS, command line switches are ignored.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
==========

[Bence, 2016-04-21 11:33:32]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-04-21 11:33:33]

Ryan: PTAL at chrome/browser/io_thread*,
ios/chrome/browser/ios_chrome_io_thread*, and the new component.  Also, would
you be willing to co-own this new component with me?  Thank you.

[Bence, 2016-04-21 13:00:12]

bnc@chromium.org changed reviewers:
+ alokp@chromium.org, mek@chromium.org, pfeldman@chromium.org,
sdefresne@chromium.org, torne@chromium.org

[Bence, 2016-04-21 13:00:13]

pfeldman: PTAL at content/
sdefresne: PTAL at components/ and ios/
torne: PTAL at android_webview/
alokp: PTAL at chromecast/

[Bence, 2016-04-21 13:05:11]

bnc@chromium.org changed reviewers:
+ felt@chromium.org, pastarmovj@chromium.org, pkasting@chromium.org,
vabr@chromium.org

[Bence, 2016-04-21 13:05:13]

Marijn: PTAL at extensions/shell/browser
felt: PTAL chrome/browser/ssl/
pastarmovj: PTAL at chrome/browser/policy/
vabr: PTAL at chrome/browser/password_manager/
Peter: PTAL at chrome/browser/ui/

[Bence, 2016-04-21 13:07:29]

bnc@chromium.org changed reviewers:
+ gene@chromium.org

[Bence, 2016-04-21 13:07:31]

gene: PTAL at chrome/service/

Thank you all.

[Torne, 2016-04-21 13:19:24]

android_webview LGTM

[pastarmovj, 2016-04-21 13:31:01]

chrome/browser/policy LGTM

[felt, 2016-04-21 14:03:16]

chrome/browser/ssl/ssl_browser_tests.cc lgtm

[alokp, 2016-04-21 16:46:54]

chromecast/ lgtm

[Marijn Kruisselbrink, 2016-04-21 16:49:28]

extensions/shell/browser LGTM

[Peter Kasting, 2016-04-21 21:05:21]

c/b/ui LGTM

[Ryan Hamilton, 2016-04-21 21:15:25]

Nice. LGTM, though I wonder if there is a shorter name. Happy to be an OWNER.

https://codereview.chromium.org/1892123003/diff/280001/components/network_ses...
File components/network_session_configurator/network_session_configurator.h
(right):

https://codereview.chromium.org/1892123003/diff/280001/components/network_ses...
components/network_session_configurator/network_session_configurator.h:38:
#endif  //
COMPONENTS_NETWORK_SESSION_CONFIGURATOR_NETWORK_SESSION_CONFIGURATOR_H_
It's too bad this name is so long.

https://codereview.chromium.org/1892123003/diff/280001/components/network_ses...
File
components/network_session_configurator/network_session_configurator_unittest.cc
(right):

https://codereview.chromium.org/1892123003/diff/280001/components/network_ses...
components/network_session_configurator/network_session_configurator_unittest.cc:5:
#include
"components/network_session_configurator/network_session_configurator.h"
Ditto. I wonder if we could shrink the name in some way?

https://codereview.chromium.org/1892123003/diff/280001/components/network_ses...
File components/network_session_configurator/switches.h (right):

https://codereview.chromium.org/1892123003/diff/280001/components/network_ses...
components/network_session_configurator/switches.h:24: extern const char
kTestingFixedHttpsPort[];
So going forward, we should put all spdy/quic/whatever flags here?

[Bence, 2016-04-22 11:11:28]

Ryan: Thank you.  I agree, I would love to have a shorter name.  Any
suggestions?  Maybe NetworkConfigurator?  Or NetSettingParser?

https://codereview.chromium.org/1892123003/diff/280001/components/network_ses...
File components/network_session_configurator/switches.h (right):

https://codereview.chromium.org/1892123003/diff/280001/components/network_ses...
components/network_session_configurator/switches.h:24: extern const char
kTestingFixedHttpsPort[];
On 2016/04/21 21:15:25, Ryan Hamilton wrote:
> So going forward, we should put all spdy/quic/whatever flags here?

Yes, that is the plan.  Since NetworkSessionConfigurator is a component and it
needs access to these flags, and components cannot depend on chrome or content,
new flags should be added here, with the understanding that when called from
iOS, command line is not parsed. (However, I have indeed seen that iOS
developers have decided to fork three of these flags as
kIOSIgnoreCertificateErrors, kIOSTestingFixedHttpPort, and
kIOSTestingFixedHttpsPort, but the rest are ignored.  Maybe there is room for a
follow-up CL.)

[Ryan Hamilton, 2016-04-22 17:59:05]

On 2016/04/22 11:11:28, Bence wrote:
> Ryan: Thank you.  I agree, I would love to have a shorter name.  Any
> suggestions?  Maybe NetworkConfigurator?  Or NetSettingParser?

Only thing I can come up with is NetworkSessionBuilder which is a few characters
shorter?

But still LGTM either way.

[Bence, 2016-04-28 18:57:19]

Gentle ping.

pfeldman: PTAL at content/
sdefresne: PTAL at components/ and ios/
vabr: PTAL at chrome/browser/password_manager/
gene: PTAL at chrome/service/

Torne, pastarmovj, felt, alokp, Marijn, Peter, Ryan:  Thank you all for
reviewing.

[pfeldman, 2016-04-29 02:16:00]

content/ lgtm

[sdefresne, 2016-04-29 18:43:45]

lgtm

BTW, I do not really understand this in your description: "Note that when called
from iOS, command line switches are ignored."

Can you clarify? Is this a change you are introducing or a fact? Command line
switch can be passed on iOS, but only to developer builds, not production
builds.

https://codereview.chromium.org/1892123003/diff/300001/components/network_ses...
File components/network_session_configurator/DEPS (right):

https://codereview.chromium.org/1892123003/diff/300001/components/network_ses...
components/network_session_configurator/DEPS:2: "+base",
nit: can you sort alphabetically?

https://codereview.chromium.org/1892123003/diff/300001/components/network_ses...
File
components/network_session_configurator/network_session_configurator_unittest.cc
(right):

https://codereview.chromium.org/1892123003/diff/300001/components/network_ses...
components/network_session_configurator/network_session_configurator_unittest.cc:1:
// Copyright (c) 2016 The Chromium Authors. All rights reserved.
nit, optional: I think we are no longer supposed to use the (c) after copyright
(at least tools/boilerplate.py does not include it)

[Bence, 2016-05-02 20:23:44]

Description was changed from

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator to this component.  Note that when
called from iOS, command line switches are ignored.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
==========

to

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator to this component.  Note that
currently command line switches are ignored.  To preserve this behavior,
this CL calls network_session_configurator::ParseFieldTrials() from
IOSChromeIOThread, which also ignores command line switches.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
==========

[Bence, 2016-05-02 20:26:47]

vabr: PTAL at chrome/browser/password_manager/
gene: PTAL at chrome/service/

pfeldman, sdefresne:  Thank you.  I changed the CL description, I hope it reads
better now.

https://codereview.chromium.org/1892123003/diff/300001/components/network_ses...
File components/network_session_configurator/DEPS (right):

https://codereview.chromium.org/1892123003/diff/300001/components/network_ses...
components/network_session_configurator/DEPS:2: "+base",
On 2016/04/29 18:43:45, sdefresne wrote:
> nit: can you sort alphabetically?

Done.

https://codereview.chromium.org/1892123003/diff/300001/components/network_ses...
File
components/network_session_configurator/network_session_configurator_unittest.cc
(right):

https://codereview.chromium.org/1892123003/diff/300001/components/network_ses...
components/network_session_configurator/network_session_configurator_unittest.cc:1:
// Copyright (c) 2016 The Chromium Authors. All rights reserved.
On 2016/04/29 18:43:45, sdefresne wrote:
> nit, optional: I think we are no longer supposed to use the (c) after
copyright
> (at least tools/boilerplate.py does not include it)

Done.

[vabr (Chromium), 2016-05-03 08:08:47]

chrome/browser/password_manager/password_manager_browsertest.cc LGTM.

Sorry for the late answer, I'm not sure how did I miss this.

Cheers,
Vaclav

[Bence, 2016-05-03 20:28:28]

bnc@chromium.org changed reviewers:
+ scottbyer@chromium.org, thakis@chromium.org

[Bence, 2016-05-03 20:28:29]

Nico: PTAL at chrome/browser/BUILD.gn, chrome/common/BUILD.gn, and
chrome/common/DEPS.  Thank you.
Scott: PTAL at chrome/service.  Thank you.
vabr: Thank you.

[Bence, 2016-05-11 19:48:47]

On 2016/05/03 20:28:29, Bence OOO until May 23 wrote:
> Nico: PTAL at chrome/browser/BUILD.gn, chrome/common/BUILD.gn, and
> chrome/common/DEPS.  Thank you.
> Scott: PTAL at chrome/service.  Thank you.
> vabr: Thank you.

Ping Nico, ping Scott and/or gene.  Thank you.

[Bence, 2016-05-19 17:28:17]

bnc@chromium.org changed reviewers:
+ sky@chromium.org

[Bence, 2016-05-19 17:28:19]

sky: PTAL at chrome/browser/BUILD.gn, chrome/common/BUILD.gn, and
chrome/common/DEPS.  (Nico is on vacation.)

Ping Scott and gene.

Thank you.

[sky, 2016-05-19 19:13:36]

Said files LGTM

[Ryan Hamilton, 2016-05-19 20:52:13]

I suspect io_thread.cc (et. al.) have evolved a bit since this CL started. How
do you plan to ensure that all such changes are incorporated in this CL?

[Bence, 2016-05-19 23:57:57]

On 2016/05/19 20:52:13, Ryan Hamilton wrote:
> I suspect io_thread.cc (et. al.) have evolved a bit since this CL started. How
> do you plan to ensure that all such changes are incorporated in this CL?

Good question.  Every "Rebase" Patch Set I created by looking at the git log on
io_thread{.h,.cc,_unittest.cc} and ios_chrome_io_thread.{h,mm}, and
incorporating the changes in NetworkSessionConfigurator.  I will have to do this
again once https://crrev.com/1956573004 lands.

[Scott Byer, 2016-05-23 16:39:59]

LGTM for service.

On 2016/05/11 at 19:48:47, bnc wrote:
> On 2016/05/03 20:28:29, Bence OOO until May 23 wrote:
> > Nico: PTAL at chrome/browser/BUILD.gn, chrome/common/BUILD.gn, and
> > chrome/common/DEPS.  Thank you.
> > Scott: PTAL at chrome/service.  Thank you.
> > vabr: Thank you.
> 
> Ping Nico, ping Scott and/or gene.  Thank you.

[Nico, 2016-05-23 16:56:58]

chrome/ lgtm, but:

https://codereview.chromium.org/1892123003/diff/320001/components/network_ses...
File components/network_session_configurator/switches.cc (right):

https://codereview.chromium.org/1892123003/diff/320001/components/network_ses...
components/network_session_configurator/switches.cc:9: // clang-format off
why? drop this

[Vitaly Buka (NO REVIEWS), 2016-05-23 20:09:17]

vitalybuka@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2016-05-23 20:09:18]

lgtm

[Bence, 2016-05-23 23:25:39]

Thank you all.

https://codereview.chromium.org/1892123003/diff/320001/components/network_ses...
File components/network_session_configurator/switches.cc (right):

https://codereview.chromium.org/1892123003/diff/320001/components/network_ses...
components/network_session_configurator/switches.cc:9: // clang-format off
On 2016/05/23 16:56:58, Nico wrote:
> why? drop this

Done.

[Bence, 2016-05-24 06:38:24]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-05-24 06:38:25]

The patchset sent to the CQ was uploaded after l-g-t-m from felt@chromium.org,
torne@chromium.org, rch@chromium.org, alokp@chromium.org, pkasting@chromium.org,
mek@chromium.org, pastarmovj@chromium.org, pfeldman@chromium.org,
sdefresne@chromium.org, sky@chromium.org, thakis@chromium.org,
vabr@chromium.org, scottbyer@chromium.org, vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/1892123003/#ps380001
(title: "Rebase on https://crrev.com/1945513002.")

[commit-bot: I haz the power, 2016-05-24 06:38:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1892123003/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1892123003/380001

[commit-bot: I haz the power, 2016-05-24 07:40:58]

Description was changed from

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator to this component.  Note that
currently command line switches are ignored.  To preserve this behavior,
this CL calls network_session_configurator::ParseFieldTrials() from
IOSChromeIOThread, which also ignores command line switches.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
==========

to

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator to this component.  Note that
currently command line switches are ignored.  To preserve this behavior,
this CL calls network_session_configurator::ParseFieldTrials() from
IOSChromeIOThread, which also ignores command line switches.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
==========

[commit-bot: I haz the power, 2016-05-24 07:41:04]

Committed patchset #20 (id:380001)

[commit-bot: I haz the power, 2016-05-24 07:42:32]

Description was changed from

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator to this component.  Note that
currently command line switches are ignored.  To preserve this behavior,
this CL calls network_session_configurator::ParseFieldTrials() from
IOSChromeIOThread, which also ignores command line switches.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616
==========

to

==========
Add components/network_session_configurator.

Factor out IOThread::NetworkSessionConfigurator to
components/network_session_configurator.

Remove duplicate code from IOSChromeIOThread, use
components/network_session_configurator instead.

Move all command line switches required by
components/network_session_configurator to this component.  Note that
currently command line switches are ignored.  To preserve this behavior,
this CL calls network_session_configurator::ParseFieldTrials() from
IOSChromeIOThread, which also ignores command line switches.

Background: IOThread was forked to IOSChromeIOThread as part of an effort to
remove the dependency of //ios on //chrome.  However, field trial and command
line parsing logic is shared.  This CL refactors said logic from IOThread and
from IOSChromeIOThread to //components and removes code duplication.

BUG=586616

Committed: https://crrev.com/210d6f3dc4f72563db1ba760dd1a2e53fd3822ef
Cr-Commit-Position: refs/heads/master@{#395540}
==========

[commit-bot: I haz the power, 2016-05-24 07:42:35]

Patchset 20 (id:??) landed as
https://crrev.com/210d6f3dc4f72563db1ba760dd1a2e53fd3822ef
Cr-Commit-Position: refs/heads/master@{#395540}

[jam, 2016-06-28 16:48:54]

I just saw this.

This indirectly adds a dependency from content/ to

components/data_reduction_proxy
components/variations
components/version_info

which content explicitly didn't want to depend on before. Please undo the
dependency from content/ to network_session_configurator/