content/common/gpu/media/android_copying_backing_strategy.cc - Issue 1892013002: ReleaseOutputBuffer to surface back and front buffers where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/android_copying_backing_strategy.cc

Issue 1892013002: ReleaseOutputBuffer to surface back and front buffers where possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanerer. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/android_copying_backing_strategy.h ('k') | content/common/gpu/media/android_deferred_rendering_backing_strategy.h » ('j') | content/common/gpu/media/android_video_decode_accelerator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/android_copying_backing_strategy.cc

diff --git a/content/common/gpu/media/android_copying_backing_strategy.cc b/content/common/gpu/media/android_copying_backing_strategy.cc

index 53faeef96ffc522a7f1bba8e0c96dda3afc44a84..be01f7ce3948a13046c363723f48ee9838efec23 100644

--- a/content/common/gpu/media/android_copying_backing_strategy.cc

+++ b/content/common/gpu/media/android_copying_backing_strategy.cc

@@ -56,7 +56,7 @@ gfx::ScopedJavaSurface AndroidCopyingBackingStrategy::Initialize(

void AndroidCopyingBackingStrategy::Cleanup(

bool have_context,

- const AndroidVideoDecodeAccelerator::OutputBufferMap&) {

+ const AndroidVideoDecodeAccelerator::OutputBufferMap& buffers) {

DCHECK(state_provider_->ThreadChecker().CalledOnValidThread());

if (copier_)

@@ -81,7 +81,8 @@ gfx::Size AndroidCopyingBackingStrategy::GetPictureBufferSize() const {

void AndroidCopyingBackingStrategy::UseCodecBufferForPictureBuffer(

int32_t codec_buf_index,

- const media::PictureBuffer& picture_buffer) {

+ const media::PictureBuffer& picture_buffer,

+ const std::vector<int32_t>& pictures_out_for_display) {

// Make sure that the decoder is available.

RETURN_ON_FAILURE(state_provider_, state_provider_->GetGlDecoder().get(),

"Failed to get gles2 decoder instance.", ILLEGAL_STATE);