Fix selection of "no audio processing" mode.

content/renderer/media/media_stream_audio_processor_options.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_MEDIA_STREAM_AUDIO_PROCESSOR_OPTIONS_H_
 #define CONTENT_RENDERER_MEDIA_MEDIA_STREAM_AUDIO_PROCESSOR_OPTIONS_H_
 
 #include <string>
 
 #include "base/files/file.h"
@@ skipping 65 matching lines @@
 
   // Gets the property of echo cancellation defined in |constraints_|. The
   // returned value depends on a combination of |effects_|, |kEchoCancellation|
   // and |kGoogEchoCancellation| in |constraints_|.
   bool GetEchoCancellationProperty() const;
 
   // Returns true if all the mandatory constraints in |constraints_| are valid;
   // Otherwise return false.
   bool IsValid() const;
 
+  // Exposed for testing.
+  bool default_audio_processing_constraint_value() const {

[tommi (sloooow) - chröme, 2016/04/15 13:46:35]

prefer GetDefaultAudioProcessingConstraintValueForTesting().

the "ForTesting" postfix is the most commonly used indicator used to make sure a
method isn't used by non-test code.

Alternatively, you could make that member variable protected (not private) and
expose it in a derived test class.  That way, the public interface isn't
affected.

+    return default_audio_processing_constraint_value_;
+  }
+
  private:
   // Gets the default value of constraint named by |key| in |constraints|.
   bool GetDefaultValueForConstraint(const std::string& key) const;
   const blink::WebMediaConstraints constraints_;
   const int effects_;
   bool default_audio_processing_constraint_value_;
 };
 
 // A helper class to log echo information in general and Echo Cancellation
 // quality in particular.
@@ skipping 43 matching lines @@
 
 // Returns the array geometry from the media constraints if existing and
 // otherwise that provided by the input device.
 CONTENT_EXPORT std::vector<webrtc::Point> GetArrayGeometryPreferringConstraints(
     const MediaAudioConstraints& audio_constraints,
     const MediaStreamDevice::AudioDeviceParameters& input_params);
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_MEDIA_STREAM_AUDIO_PROCESSOR_OPTIONS_H_