base/metrics/persistent_memory_allocator.h - Issue 1891913002: Support saving browser metrics to disk and reading them during next run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_memory_allocator.h

Issue 1891913002: Support saving browser metrics to disk and reading them during next run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments by Alexei; delete saved metrics file if reporting not enabled Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/metrics/persistent_histogram_allocator.cc ('k') | base/metrics/persistent_memory_allocator.cc » ('j') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/metrics/persistent_memory_allocator.h

diff --git a/base/metrics/persistent_memory_allocator.h b/base/metrics/persistent_memory_allocator.h

index 4c0db5264a8f810721653d130c6428437ef5f9aa..56983ac3a114dd0fd22c8b5cda4f7700cc582e6b 100644

--- a/base/metrics/persistent_memory_allocator.h

+++ b/base/metrics/persistent_memory_allocator.h

@@ -12,6 +12,7 @@

#include "base/atomicops.h"

#include "base/base_export.h"

+#include "base/files/file_path.h"

#include "base/gtest_prod_util.h"

#include "base/macros.h"

#include "base/strings/string_piece.h"

@@ -126,6 +127,10 @@ class BASE_EXPORT PersistentMemoryAllocator {

kTypeIdAny = 0 // Match any type-id inside GetAsObject().

};

+ // This is the standard file extension (suitable for being passed to the

+ // AddExtension() method of base::FilePath) for dumps of persistent memory.

+ static const base::FilePath::CharType kFileExtension[];

// The allocator operates on any arbitrary block of memory. Creation and

// persisting or sharing of that block with another process is the

// responsibility of the caller. The allocator needs to know only the