base/metrics/persistent_memory_allocator.cc - Issue 1891913002: Support saving browser metrics to disk and reading them during next run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_memory_allocator.cc

Issue 1891913002: Support saving browser metrics to disk and reading them during next run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments by Alexei; delete saved metrics file if reporting not enabled Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/metrics/persistent_memory_allocator.h ('k') | base/metrics/sparse_histogram.h » ('j') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/metrics/persistent_memory_allocator.cc

diff --git a/base/metrics/persistent_memory_allocator.cc b/base/metrics/persistent_memory_allocator.cc

index 604971d3bcd5dfc6f53a01e1df13b4ea5849e88c..a6588d85e304afce2fbb49aac93a5702d8878107 100644

--- a/base/metrics/persistent_memory_allocator.cc

+++ b/base/metrics/persistent_memory_allocator.cc

@@ -117,6 +117,9 @@ const PersistentMemoryAllocator::Reference

PersistentMemoryAllocator::kReferenceQueue =

offsetof(SharedMetadata, queue);

+const base::FilePath::CharType PersistentMemoryAllocator::kFileExtension[] =

+ FILE_PATH_LITERAL(".pma");

PersistentMemoryAllocator::Iterator::Iterator(

const PersistentMemoryAllocator* allocator)

: allocator_(allocator), last_record_(kReferenceQueue), record_count_(0) {}

« no previous file with comments | « base/metrics/persistent_memory_allocator.h ('k') | base/metrics/sparse_histogram.h » ('j') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('J')