components/autofill/core/browser/autofill_profile.h - Issue 1891903002: [Autofill] Set basic information when adding a new profiles and credit cards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_profile.h

Issue 1891903002: [Autofill] Set basic information when adding a new profiles and credit cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test that was added in rebase and removed unnecessary test. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/autofill_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_profile.h

diff --git a/components/autofill/core/browser/autofill_profile.h b/components/autofill/core/browser/autofill_profile.h

index d2784c4058c54082091606f011a8d1f2ac995b80..735cc6aac68366b95654089739f727c52ea7e4c4 100644

--- a/components/autofill/core/browser/autofill_profile.h

+++ b/components/autofill/core/browser/autofill_profile.h

@@ -99,9 +99,9 @@ class AutofillProfile : public AutofillDataModel {

bool operator==(const AutofillProfile& profile) const;

virtual bool operator!=(const AutofillProfile& profile) const;

- // Returns concatenation of full name and address line 1. This acts as the

- // basis of comparison for new values that are submitted through forms to

- // aid with correct aggregation of new data.

+ // Returns concatenation of first name, last name, address line 1 and city.

+ // This acts as the basis of comparison for new values that are submitted

+ // through forms to aid with correct aggregation of new data.

const base::string16 PrimaryValue() const;

// Returns true if the data in this AutofillProfile is a subset of the data in