components/autofill/core/browser/autofill_profile.cc - Issue 1891903002: [Autofill] Set basic information when adding a new profiles and credit cards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_profile.cc

Issue 1891903002: [Autofill] Set basic information when adding a new profiles and credit cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test that was added in rebase and removed unnecessary test. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_profile.h ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_profile.cc

diff --git a/components/autofill/core/browser/autofill_profile.cc b/components/autofill/core/browser/autofill_profile.cc

index 86d3e4c05833df0df077c40ea7b75a70aecb292e..1234c0c7257b331d3c06c7e4f5abfeb183600280 100644

--- a/components/autofill/core/browser/autofill_profile.cc

+++ b/components/autofill/core/browser/autofill_profile.cc

@@ -432,7 +432,8 @@ bool AutofillProfile::operator!=(const AutofillProfile& profile) const {

}

const base::string16 AutofillProfile::PrimaryValue() const {

- return GetRawInfo(ADDRESS_HOME_LINE1) + GetRawInfo(ADDRESS_HOME_CITY);

+ return GetRawInfo(NAME_FIRST) + GetRawInfo(NAME_LAST) +

+ GetRawInfo(ADDRESS_HOME_LINE1) + GetRawInfo(ADDRESS_HOME_CITY);

}

bool AutofillProfile::IsSubsetOf(const AutofillProfile& profile,