Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1891863003: Revert of Rehash and clear deleted entries in weak collections during GC (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Rehash and clear deleted entries in weak collections during GC (patchset #8 id:140001 of https://codereview.chromium.org/1877233005/ ) Reason for revert: [Sheriff] Speculative revert. Suspect for gc stress crashes, like: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/5119 Original issue's description: > Rehash and clear deleted entries in weak collections during GC > > Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity. > > BUG=v8:4909 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/e093a047796d4c0575fe63d36529e7fe89b8865d > Cr-Commit-Position: refs/heads/master@{#35514} TBR=hpayer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4909 Committed: https://crrev.com/5f5a3282d4b21eb0800f1d1af85926670ba0d904 Cr-Commit-Position: refs/heads/master@{#35519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M src/heap/mark-compact.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Rehash and clear deleted entries in weak collections during GC
4 years, 8 months ago (2016-04-15 12:15:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891863003/1
4 years, 8 months ago (2016-04-15 12:15:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 12:16:04 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:17:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f5a3282d4b21eb0800f1d1af85926670ba0d904
Cr-Commit-Position: refs/heads/master@{#35519}

Powered by Google App Engine
This is Rietveld 408576698