Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1891763002:
isolate.gypi: Only load build/util/version.gypi for Windows. (Closed)
|
Created:
4 years, 8 months ago by kjellander_chromium Modified:
4 years, 8 months ago CC:
chromium-reviews Base URL:
http://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionisolate.gypi: Only load build/util/version.gypi for Windows.
It was added back in https://codereview.chromium.org/140263002 in
order to load chrome.exe on Windows.
BUG=603402
Committed: https://crrev.com/a4bd30208bc2aa105f34a9abe23f27192c62ae26
Cr-Commit-Position: refs/heads/master@{#387309}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891763002/1
Description was changed from ========== isolate.gypi: Only load build/util/version.gypi for Windows. BUG=603402 ========== to ========== isolate.gypi: Only load build/util/version.gypi for Windows. It was added back in https://codereview.chromium.org/140263002 in order to load chrome.exe on Windows. BUG=603402 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kjellander@chromium.org changed reviewers: + agrieve@chromium.org, kbr@chromium.org, maruel@chromium.org
agrieve+maruel: main review. kbr: mostly FYI since you created https://codereview.chromium.org/140263002 Looks like this is actually working. I have confirmed that it solves WebRTC's problem blocking our Android swarming effort. maruel: can we trust the trybot results on this, considering it's a change in isolate.gypi? Should more trybots run?
On 2016/04/14 13:23:14, kjellander (chromium) wrote: > agrieve+maruel: main review. > kbr: mostly FYI since you created https://codereview.chromium.org/140263002 > > Looks like this is actually working. I have confirmed that it solves WebRTC's > problem blocking our Android swarming effort. It should, lgtm. > maruel: can we trust the trybot results on this, considering it's a change in > isolate.gypi? Yes > Should more trybots run? No
On 2016/04/14 13:38:22, M-A Ruel wrote: > On 2016/04/14 13:23:14, kjellander (chromium) wrote: > > agrieve+maruel: main review. > > kbr: mostly FYI since you created https://codereview.chromium.org/140263002 > > > > Looks like this is actually working. I have confirmed that it solves WebRTC's > > problem blocking our Android swarming effort. > > It should, lgtm. > > > maruel: can we trust the trybot results on this, considering it's a change in > > isolate.gypi? > > Yes > > > Should more trybots run? > > No stamp lgtm
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891763002/1
Message was sent while issue was closed.
Description was changed from ========== isolate.gypi: Only load build/util/version.gypi for Windows. It was added back in https://codereview.chromium.org/140263002 in order to load chrome.exe on Windows. BUG=603402 ========== to ========== isolate.gypi: Only load build/util/version.gypi for Windows. It was added back in https://codereview.chromium.org/140263002 in order to load chrome.exe on Windows. BUG=603402 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== isolate.gypi: Only load build/util/version.gypi for Windows. It was added back in https://codereview.chromium.org/140263002 in order to load chrome.exe on Windows. BUG=603402 ========== to ========== isolate.gypi: Only load build/util/version.gypi for Windows. It was added back in https://codereview.chromium.org/140263002 in order to load chrome.exe on Windows. BUG=603402 Committed: https://crrev.com/a4bd30208bc2aa105f34a9abe23f27192c62ae26 Cr-Commit-Position: refs/heads/master@{#387309} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a4bd30208bc2aa105f34a9abe23f27192c62ae26 Cr-Commit-Position: refs/heads/master@{#387309} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
