Fixes to make GPU tests run in isolated mode.

Fixes to make GPU tests run in isolated mode.

1) To match the gyp dependencies, move clearkeycdmadapter binaries, plugins/,
   lib32/ and lib64/ from chrome.isolate to browser_tests.isolate.

2) On Windows, include <(version_full).manifest in chrome.isolate to be able
   to execute chrome.exe. Add needed chrome_child.dll and chrome_elf.dll.

3) Add libEGL.dll and libGLESv2.dll dependencies to gpu.gyp:gl_tests and a
   new angle.isolate; refer to it from gl_tests.isolate and
   gles2_conform_test.isolate.

4) Copy run_gpu_test to run_gpu_test.py, and invoke that instead in
   telemetry_gpu_test.isolate, to make this isolate work on Windows.

BUG=321878, 334539
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245283

[Ken Russell (switch to Gerrit), 2014-01-15 23:15:43]

maruel: please review build/, chrome/, and content/test/gpu/ changes
piman: please review gpu/gpu.gyp change

The tools/telemetry/ change will be removed in a subsequent version of this CL,
before this lands.

Thanks.

[M-A Ruel, 2014-01-15 23:29:06]

About
"1) To match the gyp dependencies, move clearkeycdmadapter binaries, plugins/,
lib32/ and lib64/ from chrome.isolate to browser_tests.isolate."

I think the reverse should be done; the corresponding gyp targets should be
marked as dependencies to chrome_run.

https://codereview.chromium.org/140263002/diff/30001/build/isolate.gypi
File build/isolate.gypi (right):

https://codereview.chromium.org/140263002/diff/30001/build/isolate.gypi#newco...
build/isolate.gypi:80: '--extra-variable', 'version_full=<(version_full)',
Please update build/android/gtest/setup.py too.

https://codereview.chromium.org/140263002/diff/30001/chrome/browser_tests.iso...
File chrome/browser_tests.isolate (right):

https://codereview.chromium.org/140263002/diff/30001/chrome/browser_tests.iso...
chrome/browser_tests.isolate:19: '<(PRODUCT_DIR)/libclearkeycdm.so',
They are already in in chrome.isolate

https://codereview.chromium.org/140263002/diff/30001/chrome/telemetry.isolate
File chrome/telemetry.isolate (right):

https://codereview.chromium.org/140263002/diff/30001/chrome/telemetry.isolate...
chrome/telemetry.isolate:39: ['OS=="android" or OS=="linux"', {
This was removed here
https://codereview.chromium.org/138143010/diff/1/chrome/telemetry.isolate

so you'll want to sync.

[Ken Russell (switch to Gerrit), 2014-01-15 23:32:31]

On 2014/01/15 23:29:06, M-A Ruel wrote:
> About
> "1) To match the gyp dependencies, move clearkeycdmadapter binaries, plugins/,
> lib32/ and lib64/ from chrome.isolate to browser_tests.isolate."
> 
> I think the reverse should be done; the corresponding gyp targets should be
> marked as dependencies to chrome_run.

Per http://crbug.com/334539 , I considered that, but the truth is that these
binaries are dependents of browser_tests, not chrome. Therefore they should not
be in chrome.isolate, but browser_tests.isolate.

[Ken Russell (switch to Gerrit), 2014-01-15 23:46:44]

https://codereview.chromium.org/140263002/diff/30001/build/isolate.gypi
File build/isolate.gypi (right):

https://codereview.chromium.org/140263002/diff/30001/build/isolate.gypi#newco...
build/isolate.gypi:80: '--extra-variable', 'version_full=<(version_full)',
On 2014/01/15 23:29:07, M-A Ruel wrote:
> Please update build/android/gtest/setup.py too.

I'll work on updating src/build/android/pylib/gtest/setup.py . Will need some
help as I don't know how to invoke it to test any changes.

https://codereview.chromium.org/140263002/diff/30001/chrome/browser_tests.iso...
File chrome/browser_tests.isolate (right):

https://codereview.chromium.org/140263002/diff/30001/chrome/browser_tests.iso...
chrome/browser_tests.isolate:19: '<(PRODUCT_DIR)/libclearkeycdm.so',
On 2014/01/15 23:29:07, M-A Ruel wrote:
> They are already in in chrome.isolate

Understood; please see the CL description.

https://codereview.chromium.org/140263002/diff/30001/chrome/telemetry.isolate
File chrome/telemetry.isolate (right):

https://codereview.chromium.org/140263002/diff/30001/chrome/telemetry.isolate...
chrome/telemetry.isolate:39: ['OS=="android" or OS=="linux"', {
On 2014/01/15 23:29:07, M-A Ruel wrote:
> This was removed here
> https://codereview.chromium.org/138143010/diff/1/chrome/telemetry.isolate
> 
> so you'll want to sync.

Yes, I mentioned that in the CL description. That other CL hasn't landed yet.
I'll update this one once it does.

[piman, 2014-01-15 23:49:03]

lgtm

[M-A Ruel, 2014-01-15 23:58:49]

As per offline discussion, lgtm.

If someone needs nacl or fuzzyview stuff with chrome.isolated, they can fix the
gyp chrome_run target dependencies.

No need to update the android script, because the variable has no effect on
files selected on android.

[commit-bot: I haz the power, 2014-01-16 16:25:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kbr@chromium.org/140263002/210001

[commit-bot: I haz the power, 2014-01-16 19:34:49]

Change committed as 245283