Issue 18917003: A bug in AllocationSite::GetMode(from, to) meant that we didn't update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18917003: A bug in AllocationSite::GetMode(from, to) meant that we didn't update (Closed)

Created:
7 years, 5 months ago by mvstanton

Modified:
7 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

A bug in AllocationSite::GetMode(from, to) meant that we didn't update boilerplates for SMI to SMI_HOLEY transitions. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15617

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback addressed #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	src/objects-inl.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	test/mjsunit/allocation-site-info.js	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Toon, here is the code we discussed. Thx for spotting :) --Michael

7 years, 5 months ago (2013-07-11 09:33:23 UTC) #1

Toon Verwaest

lgtm with comment https://codereview.chromium.org/18917003/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/18917003/diff/1/src/objects-inl.h#newcode1339 src/objects-inl.h:1339: from != to) { Use IsMoreGeneralElementsKind ...

7 years, 5 months ago (2013-07-11 09:35:08 UTC) #2

mvstanton

Committed patchset #2 manually as r15617 (presubmit successful).

7 years, 5 months ago (2013-07-11 09:39:27 UTC) #3

mvstanton

7 years, 5 months ago (2013-07-11 13:01:33 UTC) #4

Message was sent while issue was closed.

thanks!

https://codereview.chromium.org/18917003/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/18917003/diff/1/src/objects-inl.h#newcode1339
src/objects-inl.h:1339: from != to) {
On 2013/07/11 09:35:08, Toon Verwaest wrote:
> Use IsMoreGeneralElementsKind to ensure we never track backwards.

Done.

Expand Messages | Collapse Messages