Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: src/objects-inl.h

Issue 18917003: A bug in AllocationSite::GetMode(from, to) meant that we didn't update (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Feedback addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/allocation-site-info.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1317 matching lines...) Expand 10 before | Expand all | Expand 10 after
1328 } 1328 }
1329 1329
1330 return DONT_TRACK_ALLOCATION_SITE; 1330 return DONT_TRACK_ALLOCATION_SITE;
1331 } 1331 }
1332 1332
1333 1333
1334 AllocationSiteMode AllocationSite::GetMode(ElementsKind from, 1334 AllocationSiteMode AllocationSite::GetMode(ElementsKind from,
1335 ElementsKind to) { 1335 ElementsKind to) {
1336 if (FLAG_track_allocation_sites && 1336 if (FLAG_track_allocation_sites &&
1337 IsFastSmiElementsKind(from) && 1337 IsFastSmiElementsKind(from) &&
1338 (IsFastObjectElementsKind(to) || IsFastDoubleElementsKind(to))) { 1338 IsMoreGeneralElementsKindTransition(from, to)) {
1339 return TRACK_ALLOCATION_SITE; 1339 return TRACK_ALLOCATION_SITE;
1340 } 1340 }
1341 1341
1342 return DONT_TRACK_ALLOCATION_SITE; 1342 return DONT_TRACK_ALLOCATION_SITE;
1343 } 1343 }
1344 1344
1345 1345
1346 MaybeObject* JSObject::EnsureCanContainHeapObjectElements() { 1346 MaybeObject* JSObject::EnsureCanContainHeapObjectElements() {
1347 ValidateElements(); 1347 ValidateElements();
1348 ElementsKind elements_kind = map()->elements_kind(); 1348 ElementsKind elements_kind = map()->elements_kind();
(...skipping 4833 matching lines...) Expand 10 before | Expand all | Expand 10 after
6182 #undef WRITE_UINT32_FIELD 6182 #undef WRITE_UINT32_FIELD
6183 #undef READ_SHORT_FIELD 6183 #undef READ_SHORT_FIELD
6184 #undef WRITE_SHORT_FIELD 6184 #undef WRITE_SHORT_FIELD
6185 #undef READ_BYTE_FIELD 6185 #undef READ_BYTE_FIELD
6186 #undef WRITE_BYTE_FIELD 6186 #undef WRITE_BYTE_FIELD
6187 6187
6188 6188
6189 } } // namespace v8::internal 6189 } } // namespace v8::internal
6190 6190
6191 #endif // V8_OBJECTS_INL_H_ 6191 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/allocation-site-info.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698