Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1891663003: Suppress flaky test RecentTabsSubMenuModelTest MaxSessionsAndRecency (Closed)

Created:
4 years, 8 months ago by rjkroege
Modified:
4 years, 8 months ago
Reviewers:
Finnur, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress flaky test RecentTabsSubMenuModelTest MaxSessionsAndRecency BUG=603744 TBR=finnur@chromium.org Committed: https://crrev.com/325e1b5f4a227912744dd561163884d734f02de6 Cr-Commit-Position: refs/heads/master@{#387513}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 chunk +8 lines, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891663003/1
4 years, 8 months ago (2016-04-15 00:40:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 01:37:27 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/325e1b5f4a227912744dd561163884d734f02de6 Cr-Commit-Position: refs/heads/master@{#387513}
4 years, 8 months ago (2016-04-15 01:38:53 UTC) #5
jam
4 years, 8 months ago (2016-04-15 17:03:04 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1891663003/diff/1/chrome/browser/ui/toolbar/r...
File chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc (right):

https://codereview.chromium.org/1891663003/diff/1/chrome/browser/ui/toolbar/r...
chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc:499: #if
defined(WIN) || defined(LINUX)
this doesn't work since it needs to be OS_WIN or OS_LINUX

Powered by Google App Engine
This is Rietveld 408576698