Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1993)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Issue 1891663003: Suppress flaky test RecentTabsSubMenuModelTest MaxSessionsAndRecency (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
index a04132a5f1fb3d7bd22654e43c1469654fcc8edc..9413acf2b77bd271d7371fd522f9d8dd6262515b 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
@@ -494,7 +494,14 @@ TEST_F(RecentTabsSubMenuModelTest, OtherDevices) {
EXPECT_TRUE(model.GetURLAndTitleForItemAtIndex(12, &url, &title));
}
-TEST_F(RecentTabsSubMenuModelTest, MaxSessionsAndRecency) {
+// Per http://crbug.com/603744, MaxSessionsAndRecenty fails intermittently on
+// windows and linux.
+#if defined(WIN) || defined(LINUX)
jam 2016/04/15 17:03:04 this doesn't work since it needs to be OS_WIN or O
+#define MAYBE_MaxSessionsAndRecency DISABLED_MaxSessionsAndRecency
+#else
+#define MAYBE_MaxSessionsAndRecency MaxSessionsAndRecency
+#endif
+TEST_F(RecentTabsSubMenuModelTest, MAYBE_MaxSessionsAndRecency) {
// Create 4 sessions : each session has 1 window with 1 tab each.
RecentTabsBuilderTestHelper recent_tabs_builder;
for (int s = 0; s < 4; ++s) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698