Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1891643002: Reader Mode distillability uses Mojo (Closed)

Created:
4 years, 8 months ago by mdjones
Modified:
4 years, 8 months ago
Reviewers:
wychen
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reader Mode distillability uses Mojo This change converts the distillability code from using the deprecated Chromium IPC to using Mojo. BUG=603349 Committed: https://crrev.com/8d71187700cce73cfd8b2a9b2fc859a051564dd8 Cr-Commit-Position: refs/heads/master@{#387644}

Patch Set 1 #

Patch Set 2 : remove unused file #

Patch Set 3 : undo horrible mistake #

Patch Set 4 : fix gyp #

Total comments: 2

Patch Set 5 : add web contents check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -111 lines) Patch
M components/dom_distiller.gypi View 1 2 3 4 chunks +1 line, -20 lines 0 comments Download
M components/dom_distiller/content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/content/browser/distillability_driver.h View 2 chunks +10 lines, -3 lines 0 comments Download
M components/dom_distiller/content/browser/distillability_driver.cc View 1 2 3 4 2 chunks +37 lines, -13 lines 0 comments Download
M components/dom_distiller/content/common/BUILD.gn View 1 chunk +1 line, -15 lines 0 comments Download
A components/dom_distiller/content/common/distillability_service.mojom View 1 chunk +11 lines, -0 lines 0 comments Download
D components/dom_distiller/content/common/distiller_messages.h View 1 chunk +0 lines, -21 lines 0 comments Download
D components/dom_distiller/content/common/distiller_messages.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M components/dom_distiller/content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/content/renderer/distillability_agent.cc View 2 chunks +10 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
mdjones
ptal
4 years, 8 months ago (2016-04-14 01:15:16 UTC) #2
wychen
lgtm
4 years, 8 months ago (2016-04-14 20:33:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891643002/60001
4 years, 8 months ago (2016-04-15 00:25:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/212895)
4 years, 8 months ago (2016-04-15 01:10:24 UTC) #7
wychen
https://codereview.chromium.org/1891643002/diff/60001/components/dom_distiller/content/browser/distillability_driver.cc File components/dom_distiller/content/browser/distillability_driver.cc (right): https://codereview.chromium.org/1891643002/diff/60001/components/dom_distiller/content/browser/distillability_driver.cc#newcode76 components/dom_distiller/content/browser/distillability_driver.cc:76: web_contents()->GetMainFrame()->GetServiceRegistry() I guess " if (web_contents()) return;" is needed.
4 years, 8 months ago (2016-04-15 06:11:23 UTC) #8
mdjones
https://codereview.chromium.org/1891643002/diff/60001/components/dom_distiller/content/browser/distillability_driver.cc File components/dom_distiller/content/browser/distillability_driver.cc (right): https://codereview.chromium.org/1891643002/diff/60001/components/dom_distiller/content/browser/distillability_driver.cc#newcode76 components/dom_distiller/content/browser/distillability_driver.cc:76: web_contents()->GetMainFrame()->GetServiceRegistry() On 2016/04/15 06:11:22, wychen wrote: > I guess ...
4 years, 8 months ago (2016-04-15 15:50:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891643002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891643002/80001
4 years, 8 months ago (2016-04-15 15:51:25 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-15 18:11:59 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 18:13:11 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8d71187700cce73cfd8b2a9b2fc859a051564dd8
Cr-Commit-Position: refs/heads/master@{#387644}

Powered by Google App Engine
This is Rietveld 408576698