Reader Mode triggers after tab crash

Reader Mode triggers after tab crash

After a tab crashes, the IPC pipe is invalidated. This removes the
binding to create the receiving end of the distillability service.
This change re-adds the binding after each navigation event.

BUG=603673
Committed: https://crrev.com/a5e2d57e31704b582b35eaf4577850ba97d0b9e2
Cr-Commit-Position: refs/heads/master@{#387798}

[mdjones, 2016-04-14 20:13:17]

mdjones@chromium.org changed reviewers:
+ wychen@chromium.org

[mdjones, 2016-04-14 20:13:17]

ptal

[wychen, 2016-04-14 20:41:25]

lgtm

https://codereview.chromium.org/1883023004/diff/1/components/dom_distiller/co...
File components/dom_distiller/content/browser/distillability_driver.cc (right):

https://codereview.chromium.org/1883023004/diff/1/components/dom_distiller/co...
components/dom_distiller/content/browser/distillability_driver.cc:49:
content::WebContentsObserver::Observe(NULL);
nit: nullptr
It's my fault though.

[mdjones, 2016-04-15 00:29:45]

https://codereview.chromium.org/1883023004/diff/1/components/dom_distiller/co...
File components/dom_distiller/content/browser/distillability_driver.cc (right):

https://codereview.chromium.org/1883023004/diff/1/components/dom_distiller/co...
components/dom_distiller/content/browser/distillability_driver.cc:49:
content::WebContentsObserver::Observe(NULL);
On 2016/04/14 20:41:25, wychen wrote:
> nit: nullptr
> It's my fault though.

Done.

[wychen, 2016-04-15 06:22:21]

https://codereview.chromium.org/1883023004/diff/20001/components/dom_distille...
File components/dom_distiller/content/browser/distillability_driver.cc (right):

https://codereview.chromium.org/1883023004/diff/20001/components/dom_distille...
components/dom_distiller/content/browser/distillability_driver.cc:47:
web_contents()->GetMainFrame()->GetServiceRegistry()
Would web_cotents() always be nullptr here? If the life cycle is the same as
webcontents, maybe we don't have to remove service. We could register at
DidStartProvisionalLoad() and remove at OnDistillability is_last==true, but
seems like overkill.

[mdjones, 2016-04-15 21:04:09]

https://codereview.chromium.org/1883023004/diff/20001/components/dom_distille...
File components/dom_distiller/content/browser/distillability_driver.cc (right):

https://codereview.chromium.org/1883023004/diff/20001/components/dom_distille...
components/dom_distiller/content/browser/distillability_driver.cc:47:
web_contents()->GetMainFrame()->GetServiceRegistry()
On 2016/04/15 06:22:21, wychen wrote:
> Would web_cotents() always be nullptr here? If the life cycle is the same as
> webcontents, maybe we don't have to remove service. We could register at
> DidStartProvisionalLoad() and remove at OnDistillability is_last==true, but
> seems like overkill.

Done.

[mdjones, 2016-04-15 21:21:52]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-04-15 21:21:53]

The patchset sent to the CQ was uploaded after l-g-t-m from wychen@chromium.org
Link to the patchset: https://codereview.chromium.org/1883023004/#ps40001
(title: "different lifecycle")

[commit-bot: I haz the power, 2016-04-15 21:22:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883023004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883023004/40001

[mdjones, 2016-04-15 21:24:31]

The CQ bit was unchecked by mdjones@chromium.org

[mdjones, 2016-04-15 21:36:53]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-04-15 21:37:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883023004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883023004/40001

[commit-bot: I haz the power, 2016-04-16 00:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-16 00:59:32]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mdjones, 2016-04-16 01:03:17]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-04-16 01:03:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883023004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883023004/40001

[commit-bot: I haz the power, 2016-04-16 02:38:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-16 02:39:45]

Description was changed from

==========
Reader Mode triggers after tab crash

After a tab crashes, the IPC pipe is invalidated. This removes the
binding to create the receiving end of the distillability service.
This change re-adds the binding after each navigation event.

BUG=603673
==========

to

==========
Reader Mode triggers after tab crash

After a tab crashes, the IPC pipe is invalidated. This removes the
binding to create the receiving end of the distillability service.
This change re-adds the binding after each navigation event.

BUG=603673

Committed: https://crrev.com/a5e2d57e31704b582b35eaf4577850ba97d0b9e2
Cr-Commit-Position: refs/heads/master@{#387798}
==========

[commit-bot: I haz the power, 2016-04-16 02:39:46]

Patchset 3 (id:??) landed as
https://crrev.com/a5e2d57e31704b582b35eaf4577850ba97d0b9e2
Cr-Commit-Position: refs/heads/master@{#387798}