Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1891413002: mash: Convert OnWindowInputEventAck to use an enum for handled status (Closed)

Created:
4 years, 8 months ago by James Cook
Modified:
4 years, 8 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Convert OnWindowInputEventAck to use an enum for handled status This is clearer than an unadorned bool, especially in callbacks. It also gives us a place to add additional status values, like repost, should we want them in the future. BUG=none TEST=compiles, existing content_unittests and mojo_view_manager_lib_unittests Committed: https://crrev.com/947041b4f320211ce2532a185f55a354d8a772ae Cr-Commit-Position: refs/heads/master@{#387750}

Patch Set 1 #

Patch Set 2 : missed a file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -88 lines) Patch
M components/mus/public/cpp/input_event_handler.h View 1 chunk +6 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 3 chunks +8 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M components/mus/ws/window_manager_state_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M components/mus/ws/window_tree.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 2 chunks +6 lines, -4 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection_unittest.cc View 16 chunks +33 lines, -31 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/views/mus/platform_window_mus.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
James Cook
sky, please take a look. This is extracted from my abandoned repost-event patch.
4 years, 8 months ago (2016-04-15 21:32:22 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-15 22:19:25 UTC) #3
James Cook
Ben, can I get OWNERS for content/renderer/mus?
4 years, 8 months ago (2016-04-15 22:35:45 UTC) #5
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-15 22:45:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891413002/20001
4 years, 8 months ago (2016-04-15 22:48:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 23:42:24 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 23:43:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/947041b4f320211ce2532a185f55a354d8a772ae
Cr-Commit-Position: refs/heads/master@{#387750}

Powered by Google App Engine
This is Rietveld 408576698