Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1891393003: Hide the toolbar when in extension fullscreen on OSX (Closed)

Created:
4 years, 8 months ago by spqchan
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide the toolbar when in extension fullscreen on OSX BUG=603692 Committed: https://crrev.com/dc08b44fc987d1849f3d30661dd3af47e6bc5b38 Cr-Commit-Position: refs/heads/master@{#387971}

Patch Set 1 #

Patch Set 2 : comment nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
spqchan
PTAL
4 years, 8 months ago (2016-04-16 01:05:48 UTC) #2
Robert Sesek
lgtm
4 years, 8 months ago (2016-04-18 17:46:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891393003/20001
4 years, 8 months ago (2016-04-18 17:57:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 18:54:56 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:56:03 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dc08b44fc987d1849f3d30661dd3af47e6bc5b38
Cr-Commit-Position: refs/heads/master@{#387971}

Powered by Google App Engine
This is Rietveld 408576698