Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6401)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 1891393003: Hide the toolbar when in extension fullscreen on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 87aa090af6ebf5f0e0ab370d8601708f1af926c7..dabb33c8261e11e57c9b70e6027ea4808874c249 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -465,7 +465,7 @@ willPositionSheet:(NSWindow*)sheet
}
- (void)configurePresentationModeController {
- BOOL fullscreenForTab = [self isFullscreenForTabContent];
+ BOOL fullscreenForTab = [self isFullscreenForTabContentOrExtension];
BOOL kioskMode =
base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode);
BOOL showDropdown =
@@ -849,7 +849,7 @@ willPositionSheet:(NSWindow*)sheet
- (void)adjustUIForEnteringFullscreen {
fullscreen_mac::SlidingStyle style;
- if ([self isFullscreenForTabContent]) {
+ if ([self isFullscreenForTabContentOrExtension]) {
style = fullscreen_mac::OMNIBOX_TABS_NONE;
} else if (enteringPresentationMode_ || ![self shouldShowFullscreenToolbar]) {
style = fullscreen_mac::OMNIBOX_TABS_HIDDEN;
@@ -1245,10 +1245,11 @@ willPositionSheet:(NSWindow*)sheet
return nil;
}
-- (BOOL)isFullscreenForTabContent {
- return browser_->exclusive_access_manager()
- ->fullscreen_controller()
- ->IsWindowFullscreenForTabOrPending();
+- (BOOL)isFullscreenForTabContentOrExtension {
+ FullscreenController* controller =
+ browser_->exclusive_access_manager()->fullscreen_controller();
+ return controller->IsWindowFullscreenForTabOrPending() ||
+ controller->IsExtensionFullscreenOrPending();
}
@end // @implementation BrowserWindowController(Private)
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698