Add comment for search::MatchesOriginAndPath

Add comment for search::MatchesOriginAndPath

Also add an OWNERS entry for chrome/common/search_urls*

BUG=none

Committed: https://crrev.com/63356ae5b201b39905d461c32e91b78b7552faf4
Cr-Commit-Position: refs/heads/master@{#388500}

[Marc Treib, 2016-04-19 14:40:50]

Description was changed from

==========
Cleanup search::MatchesOriginAndPath

BUG=none
==========

to

==========
Add comment for search::MatchesOriginAndPath

Also add an OWNERS entry for chrome/common/search_urls*

BUG=none
==========

[Marc Treib, 2016-04-19 14:45:56]

treib@chromium.org changed reviewers:
+ jered@chromium.org, sreeram@chromium.org

[Marc Treib, 2016-04-19 14:45:56]

jered, sreeram: PTAL and check if my comment is accurate.
(sreeram originally added this code in
https://chromiumcodereview.appspot.com/12250033, and jered last touched it in
https://codereview.chromium.org/23455047).
Or maybe we don't actually need the http (non-s) support anymore?

msw: FYI, turns out the one-way http vs https comparison is there for a reason
:-/

[Jered, 2016-04-19 15:06:25]

On 2016/04/19 14:45:56, Marc Treib wrote:
> jered, sreeram: PTAL and check if my comment is accurate.
> (sreeram originally added this code in
> https://chromiumcodereview.appspot.com/12250033, and jered last touched it in
> https://codereview.chromium.org/23455047).
> Or maybe we don't actually need the http (non-s) support anymore?
> 
> msw: FYI, turns out the one-way http vs https comparison is there for a reason
> :-/

lgtm

I don't remember exactly what case required this funny logic but it's
intentional.
I remember that new profiles sometimes use http urls for the default search
provider, which we upgrade to https via search domain check or a redirect. And
at
the time it's possible some affected search pages were served over http.

[Marc Treib, 2016-04-19 16:34:59]

On 2016/04/19 15:06:25, Jered wrote:
> On 2016/04/19 14:45:56, Marc Treib wrote:
> > jered, sreeram: PTAL and check if my comment is accurate.
> > (sreeram originally added this code in
> > https://chromiumcodereview.appspot.com/12250033, and jered last touched it
in
> > https://codereview.chromium.org/23455047).
> > Or maybe we don't actually need the http (non-s) support anymore?
> > 
> > msw: FYI, turns out the one-way http vs https comparison is there for a
reason
> > :-/
> 
> lgtm
> 
> I don't remember exactly what case required this funny logic but it's
> intentional.
> I remember that new profiles sometimes use http urls for the default search
> provider, which we upgrade to https via search domain check or a redirect. And
> at
> the time it's possible some affected search pages were served over http.

Thanks for the explanation!
That kinda sounds like a workaround for a problem somewhere else. I've filed
crbug.com/604771 for this.

[Marc Treib, 2016-04-19 16:42:30]

treib@chromium.org changed reviewers:
+ jochen@chromium.org

[Marc Treib, 2016-04-19 16:42:31]

+jochen for owners approval.

[jochen (gone - plz use gerrit), 2016-04-20 14:26:05]

lgtm

[Marc Treib, 2016-04-20 14:27:17]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-04-20 14:27:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1891233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1891233002/20001

[commit-bot: I haz the power, 2016-04-20 15:16:54]

Description was changed from

==========
Add comment for search::MatchesOriginAndPath

Also add an OWNERS entry for chrome/common/search_urls*

BUG=none
==========

to

==========
Add comment for search::MatchesOriginAndPath

Also add an OWNERS entry for chrome/common/search_urls*

BUG=none
==========

[commit-bot: I haz the power, 2016-04-20 15:16:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:23:34]

Description was changed from

==========
Add comment for search::MatchesOriginAndPath

Also add an OWNERS entry for chrome/common/search_urls*

BUG=none
==========

to

==========
Add comment for search::MatchesOriginAndPath

Also add an OWNERS entry for chrome/common/search_urls*

BUG=none

Committed: https://crrev.com/63356ae5b201b39905d461c32e91b78b7552faf4
Cr-Commit-Position: refs/heads/master@{#388500}
==========

[commit-bot: I haz the power, 2016-04-22 19:23:35]

Patchset 2 (id:??) landed as
https://crrev.com/63356ae5b201b39905d461c32e91b78b7552faf4
Cr-Commit-Position: refs/heads/master@{#388500}