Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: chrome/common/search_urls.h

Issue 1891233002: Add comment for search::MatchesOriginAndPath (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment instead Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/OWNERS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/search_urls.h
diff --git a/chrome/common/search_urls.h b/chrome/common/search_urls.h
index c4bbacd2db84718a4381636386d7c55e14564a2b..8840b5f2f1401226d69c17df97bd5b2373c90a59 100644
--- a/chrome/common/search_urls.h
+++ b/chrome/common/search_urls.h
@@ -9,7 +9,11 @@ class GURL;
namespace search {
-// Returns true if |my_url| matches |other_url|.
+// Returns true if |my_url| matches |other_url| in terms of origin (i.e. host,
+// port, and scheme) and path. As a special case, this also matches if |my_url|
+// is "https://" and |other_url| is "http://" (and host, port, and path match).
+// This is so that "https://" URLs will be considered "Instant URLs" even if the
+// default search provider URL is "http://".
bool MatchesOriginAndPath(const GURL& my_url, const GURL& other_url);
} // namespace search
« no previous file with comments | « chrome/common/OWNERS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698