Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 189123002: Docserver: Correctly disambiguate between what 'platform' means in a features (Closed)

Created:
6 years, 9 months ago by not at google - send to devlin
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: Correctly disambiguate between what 'platform' means in a features file. BUG=350057 R=yoz@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255501

Patch Set 1 #

Patch Set 2 : cleanup debugging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -25 lines) Patch
M chrome/common/extensions/docs/server2/api_list_data_source_test.py View 1 chunk +14 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/features_bundle_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/features_utility.py View 1 1 chunk +14 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/permissions_data_source_test.py View 2 chunks +8 lines, -13 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/permissions.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
not at google - send to devlin
6 years, 9 months ago (2014-03-06 21:41:43 UTC) #1
not at google - send to devlin
ping.
6 years, 9 months ago (2014-03-07 00:12:32 UTC) #2
Yoyo Zhou
LGTM, but I feel like we shouldn't be reusing "platforms" for ["apps", "extensions"]. We should ...
6 years, 9 months ago (2014-03-07 00:54:38 UTC) #3
not at google - send to devlin
agree
6 years, 9 months ago (2014-03-07 01:13:07 UTC) #4
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 9 months ago (2014-03-07 01:13:12 UTC) #5
not at google - send to devlin
The CQ bit was unchecked by kalman@chromium.org
6 years, 9 months ago (2014-03-07 01:34:39 UTC) #6
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 9 months ago (2014-03-07 01:34:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/189123002/20001
6 years, 9 months ago (2014-03-07 01:47:50 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 02:36:17 UTC) #9
Message was sent while issue was closed.
Change committed as 255501

Powered by Google App Engine
This is Rietveld 408576698