Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4434)

Unified Diff: chrome/common/extensions/docs/server2/permissions_data_source_test.py

Issue 189123002: Docserver: Correctly disambiguate between what 'platform' means in a features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup debugging Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/permissions_data_source_test.py
diff --git a/chrome/common/extensions/docs/server2/permissions_data_source_test.py b/chrome/common/extensions/docs/server2/permissions_data_source_test.py
index e92b16b3af0f0218fe6d7f6fd37286a352cf7032..68eae8a205b2bdef648cd923f745877c4bacd4c6 100755
--- a/chrome/common/extensions/docs/server2/permissions_data_source_test.py
+++ b/chrome/common/extensions/docs/server2/permissions_data_source_test.py
@@ -18,31 +18,26 @@ _PERMISSION_FEATURES = {
# This will appear for extensions with a description as defined in the
# permissions.json file.
'activeTab': {
- 'name': 'activeTab',
- 'platforms': ['extensions'],
+ 'extension_types': ['extension'],
},
# This will appear for apps and extensions with an auto-generated description
# since the entry appears in _api_features.json.
'alarms': {
- 'name': 'alarms',
- 'platforms': ['apps', 'extensions'],
+ 'extension_types': ['platform_app', 'extension'],
},
# This won't appear for anything since there's no entry in permissions.json
# and it's not an API.
'audioCapture': {
- 'name': 'audioCapture',
- 'platforms': ['apps'],
+ 'extension_types': ['platform_app'],
},
# This won't appear for anything because it's private.
'commandLinePrivate': {
- 'name': 'commandLinePrivate',
- 'platforms': ['apps', 'extensions']
+ 'extension_types': ['platform_app', 'extension']
},
# This will only appear for apps with an auto-generated description because
# it's an API.
'cookies': {
- 'name': 'cookies',
- 'platforms': ['apps']
+ 'extension_types': ['platform_app']
},
}
@@ -51,11 +46,11 @@ _PERMISSIONS_JSON = {
# This will appear for both apps and extensions with a custom description,
# anchor, etc.
'host-permissions': {
- 'name': 'match pattern',
'anchor': 'custom-anchor',
+ 'extension_types': ['platform_app', 'extension'],
+ 'literal_name': True,
+ 'name': 'match pattern',
'partial': 'permissions/host_permissions.html',
- 'platforms': ['apps', 'extensions'],
- 'literal_name': True
},
# A custom 'partial' here overrides the default partial.
'activeTab': {

Powered by Google App Engine
This is Rietveld 408576698