Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1891013002: WIP: runtime switch for how to interpret SkColor -vs- srgb (Closed)

Created:
4 years, 8 months ago by reed1
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

WIP: runtime switch for how to interpret SkColor -vs- srgb Still very conflicted about the "right" way to proceed with this, but thought I'd experiment with a runtime flag, so we can practice seeing SKPs in various stages of "srgb correctness". Other aspects to either fix, or at least provide runtime switches for: - untagged images - gradients - colorshader - drawVertices BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1891013002 TBR= Committed: https://skia.googlesource.com/skia/+/87a0c223e3685b303d6b14955d398e651f8b8c84

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/core/SkColor.cpp View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/core/SkPM4fPriv.h View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
reed1
4 years, 8 months ago (2016-04-14 20:55:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891013002/20001
4 years, 8 months ago (2016-04-15 17:32:06 UTC) #7
reed1
Herb, Florin, after this lands, see if you can use the flag to toggle images ...
4 years, 8 months ago (2016-04-15 17:34:06 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 17:48:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/87a0c223e3685b303d6b14955d398e651f8b8c84

Powered by Google App Engine
This is Rietveld 408576698