Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1890953003: Remove the "line-number flakiness" by adding an img element dynamically. (Closed)

Created:
4 years, 8 months ago by Charlie Harrison
Modified:
4 years, 8 months ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Remove the "line-number flakiness" by adding an img element dynamically. [Merge to M51] This CL makes sure that when image resource is loaded it never has an associated line number (previously, it might be associated with a line number depending at what stage the image is loaded - i.e. depending on whether the HTML document parser is still on the callstack). BUG=602421 TBR=lukasza@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1882893002 Cr-Commit-Position: refs/heads/master@{#387040} (cherry picked from commit 3c3cc057a1ac5c2a9ab5a1f4932f494569db46c3)

Patch Set 1 #

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890953003/1
4 years, 8 months ago (2016-04-15 13:37:58 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-15 13:38:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890953003/1
4 years, 8 months ago (2016-04-15 13:38:58 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 13:40:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698