Remove the line-number flakiness by adding an img element dynamically.

Remove the "line-number flakiness" by adding an img element dynamically.

This CL makes sure that when image resource is loaded it never has an
associated line number (previously, it might be associated with a line
number depending at what stage the image is loaded - i.e.  depending on
whether the HTML document parser is still on the callstack).

BUG=602421
Committed: https://crrev.com/3c3cc057a1ac5c2a9ab5a1f4932f494569db46c3
Cr-Commit-Position: refs/heads/master@{#387040}

[Łukasz Anforowicz, 2016-04-13 17:10:55]

Description was changed from

==========
Remove the line-number flakiness by adding an img element dynamically.

This CL makes sure that when image resource is loaded it never has an
associated line number (previously, it might be associated with a line
number depending at what stage the image is loaded - i.e.  depending on
whether the HTML document parser is still on the callstack).

BUG=602421
==========

to

==========
Remove the "line-number flakiness" by adding an img element dynamically.

This CL makes sure that when image resource is loaded it never has an
associated line number (previously, it might be associated with a line
number depending at what stage the image is loaded - i.e.  depending on
whether the HTML document parser is still on the callstack).

BUG=602421
==========

[Łukasz Anforowicz, 2016-04-13 17:16:35]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-04-13 17:16:36]

Daniel, could you please take a look?

https://codereview.chromium.org/1882893002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html
(right):

https://codereview.chromium.org/1882893002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html:5:
img.srcset = "";
Please double-check.  AFAICT this is equivalent to an attribute without a value
in the deleted html: <img ... srcset>

[dcheng, 2016-04-13 17:18:34]

lgtm

[Łukasz Anforowicz, 2016-04-13 17:19:27]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-13 17:19:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882893002/20001

[commit-bot: I haz the power, 2016-04-13 18:30:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-13 18:31:36]

Description was changed from

==========
Remove the "line-number flakiness" by adding an img element dynamically.

This CL makes sure that when image resource is loaded it never has an
associated line number (previously, it might be associated with a line
number depending at what stage the image is loaded - i.e.  depending on
whether the HTML document parser is still on the callstack).

BUG=602421
==========

to

==========
Remove the "line-number flakiness" by adding an img element dynamically.

This CL makes sure that when image resource is loaded it never has an
associated line number (previously, it might be associated with a line
number depending at what stage the image is loaded - i.e.  depending on
whether the HTML document parser is still on the callstack).

BUG=602421

Committed: https://crrev.com/3c3cc057a1ac5c2a9ab5a1f4932f494569db46c3
Cr-Commit-Position: refs/heads/master@{#387040}
==========

[commit-bot: I haz the power, 2016-04-13 18:31:37]

Patchset 2 (id:??) landed as
https://crrev.com/3c3cc057a1ac5c2a9ab5a1f4932f494569db46c3
Cr-Commit-Position: refs/heads/master@{#387040}