Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1890853002: Add null check for page_load_metrics timing sender (Closed)

Created:
4 years, 8 months ago by Charlie Harrison
Modified:
4 years, 8 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null check for page_load_metrics timing sender BUG=603526 Committed: https://crrev.com/1e2463244f2a1dd7a20c511b4b7b17f311129a5d Cr-Commit-Position: refs/heads/master@{#387305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/page_load_metrics/renderer/metrics_render_frame_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Charlie Harrison
PTAL. This was a bug in the previous CL.
4 years, 8 months ago (2016-04-14 13:38:54 UTC) #3
Bryan McQuade
lgtm
4 years, 8 months ago (2016-04-14 13:43:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890853002/1
4 years, 8 months ago (2016-04-14 13:50:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 14:15:57 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 14:18:11 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1e2463244f2a1dd7a20c511b4b7b17f311129a5d
Cr-Commit-Position: refs/heads/master@{#387305}

Powered by Google App Engine
This is Rietveld 408576698